* [pve-devel] [PATCH manager] ui: dc/SyncWindow: realign to sync options
@ 2022-04-29 10:23 Dominik Csapak
2022-04-29 12:30 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2022-04-29 10:23 UTC (permalink / raw)
To: pve-devel
put the checkboxes in a fieldset and reuse their labels
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/dc/SyncWindow.js | 42 ++++++++++++++++++-----------------
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/www/manager6/dc/SyncWindow.js b/www/manager6/dc/SyncWindow.js
index b32926dd..1d8bef8f 100644
--- a/www/manager6/dc/SyncWindow.js
+++ b/www/manager6/dc/SyncWindow.js
@@ -119,26 +119,28 @@ Ext.define('PVE.dc.SyncWindow', {
columnB: [
{
- xtype: 'displayfield',
- fieldLabel: gettext('Remove Vanished'),
- },
- {
- xtype: 'proxmoxcheckbox',
- fieldLabel: gettext('ACL'),
- name: 'remove-vanished-acl',
- boxLabel: gettext('Remove ACLs of users and groups which are not in the sync response.'),
- },
- {
- xtype: 'proxmoxcheckbox',
- fieldLabel: gettext('Entry'),
- name: 'remove-vanished-entry',
- boxLabel: gettext('Remove users and groups that are not in the sync response.'),
- },
- {
- xtype: 'proxmoxcheckbox',
- fieldLabel: gettext('Properties'),
- name: 'remove-vanished-properties',
- boxLabel: gettext('Remove user-properties that are not in the sync response.'),
+ xtype: 'fieldset',
+ title: gettext('Remove Vanished Options'),
+ items: [
+ {
+ xtype: 'proxmoxcheckbox',
+ fieldLabel: gettext('ACL'),
+ name: 'remove-vanished-acl',
+ boxLabel: gettext('Remove ACLs of vanished users and groups.'),
+ },
+ {
+ xtype: 'proxmoxcheckbox',
+ fieldLabel: gettext('Entry'),
+ name: 'remove-vanished-entry',
+ boxLabel: gettext('Remove vanished user and group entries.'),
+ },
+ {
+ xtype: 'proxmoxcheckbox',
+ fieldLabel: gettext('Properties'),
+ name: 'remove-vanished-properties',
+ boxLabel: gettext('Remove properties from vanished users.'),
+ },
+ ],
},
{
xtype: 'displayfield',
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: dc/SyncWindow: realign to sync options
2022-04-29 10:23 [pve-devel] [PATCH manager] ui: dc/SyncWindow: realign to sync options Dominik Csapak
@ 2022-04-29 12:30 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-04-29 12:30 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
Am 4/29/22 um 12:23 schrieb Dominik Csapak:
> put the checkboxes in a fieldset and reuse their labels
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/dc/SyncWindow.js | 42 ++++++++++++++++++-----------------
> 1 file changed, 22 insertions(+), 20 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-29 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29 10:23 [pve-devel] [PATCH manager] ui: dc/SyncWindow: realign to sync options Dominik Csapak
2022-04-29 12:30 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal