all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Matthias Heiserer <m.heiserer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 qemu-server 1/1] Warn in GUI for unlikely iothread config
Date: Thu, 28 Apr 2022 10:44:49 +0200	[thread overview]
Message-ID: <20220428084449.144884-3-m.heiserer@proxmox.com> (raw)
In-Reply-To: <20220428084449.144884-1-m.heiserer@proxmox.com>

Previously, only a plaintext line in the task log showed something was off.
Now, the GUI will show it as a warning.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---

No changes from v1

 PVE/QemuServer.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 5366df2..d1f612b 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3952,7 +3952,9 @@ sub config_to_command {
 		$iothread .= ",iothread=iothread-$controller_prefix$controller";
 		push @$cmd, '-object', "iothread,id=iothread-$controller_prefix$controller";
 	    } elsif ($drive->{iothread}) {
-		warn "iothread is only valid with virtio disk or virtio-scsi-single controller, ignoring\n";
+		PVE::RESTEnvironment::log_warn(
+		    "iothread is only valid with virtio disk or virtio-scsi-single controller, ignoring\n"
+		);
 	    }
 
 	    my $queues = '';
-- 
2.30.2





  parent reply	other threads:[~2022-04-28  8:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28  8:44 [pve-devel] [PATCH v2 manager 1/2] GUI: HDEdit: check iothread by default Matthias Heiserer
2022-04-28  8:44 ` [pve-devel] [PATCH v2 manager 2/2] GUI: OS defaults: use SCSI single as default controller Matthias Heiserer
2022-04-28  8:44 ` Matthias Heiserer [this message]
2022-05-10  7:26   ` [pve-devel] [PATCH v2 qemu-server 1/1] Warn in GUI for unlikely iothread config Fabian Ebner
2022-05-10  7:33     ` Fabian Ebner
2022-05-09 15:13 ` [pve-devel] [PATCH v2 manager 1/2] GUI: HDEdit: check iothread by default Daniel Tschlatscher
2022-05-10  7:26 ` Fabian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220428084449.144884-3-m.heiserer@proxmox.com \
    --to=m.heiserer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal