[pve-devel] [PATCH manager 1/3] HDEdit: always show io thread checkbox

[pve-devel] [PATCH manager 1/3] HDEdit: always show io thread checkbox

[Matthias Heiserer]

Previously, it was in the advanced section.

In the qemu wizard, bind iothread to the SCSI controller, so that
the unlikely/impossible combination of anything other than SCSI-single
with iothread can't be accidentally selected.

However, in the guest options, iothread and SCSI controller can still
be changed independantly.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 www/manager6/qemu/HDEdit.js | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index c643ee73..9dea9984 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -251,6 +251,17 @@ Ext.define('PVE.qemu.HDInputPanel', {
 		reference: 'discard',
 		name: 'discard',
 	    },
+	    {
+		xtype: 'proxmoxcheckbox',
+		name: 'iothread',
+		fieldLabel: 'IO thread',
+		clearOnDisable: true,
+		bind: {
+		    disabled: '{!isVirtIO && !isSCSI}',
+		    // only for wizard
+		    value: '{current.scsihw === "virtio-scsi-single"}',
+		},
+	    },
 	);
 
 	advancedColumn1.push(
@@ -263,15 +274,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
 		    disabled: '{isVirtIO}',
 		},
 	    },
-	    {
-		xtype: 'proxmoxcheckbox',
-		name: 'iothread',
-		fieldLabel: 'IO thread',
-		clearOnDisable: true,
-		bind: {
-		    disabled: '{!isVirtIO && !isSCSI}',
-		},
-	    },
 	    {
 		xtype: 'proxmoxcheckbox',
 		name: 'readOnly', // `ro` in the config, we map in get/set values
-- 
2.30.2

[pve-devel] [PATCH manager 2/3] QEMU wizard: use virtio-scsi-single as default controller

[Matthias Heiserer]

Existing installs are not changed by this.
Especially in benchmarks, SCSI with iothreads is significantly faster
than normal SCSI.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 www/manager6/qemu/OSDefaults.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js
index eed9eebc..5e588a58 100644
--- a/www/manager6/qemu/OSDefaults.js
+++ b/www/manager6/qemu/OSDefaults.js
@@ -42,7 +42,7 @@ Ext.define('PVE.qemu.OSDefaults', {
 		    scsi: 2,
 		    virtio: 1,
 	    },
-	    scsihw: 'virtio-scsi-pci',
+	    scsihw: 'virtio-scsi-single',
 	};
 
        // virtio-net is in kernel since 2.6.25
-- 
2.30.2

[pve-devel] [PATCH qemu-server 3/3] Warn in REST env for unlikely iothread config

[Matthias Heiserer]

Previously, only a plaintext line in the task log showed something was off.
Now, the GUI will show it as a warning.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 PVE/QemuServer.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 5366df2..d1f612b 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3952,7 +3952,9 @@ sub config_to_command {
 		$iothread .= ",iothread=iothread-$controller_prefix$controller";
 		push @$cmd, '-object', "iothread,id=iothread-$controller_prefix$controller";
 	    } elsif ($drive->{iothread}) {
-		warn "iothread is only valid with virtio disk or virtio-scsi-single controller, ignoring\n";
+		PVE::RESTEnvironment::log_warn(
+		    "iothread is only valid with virtio disk or virtio-scsi-single controller, ignoring\n"
+		);
 	    }
 
 	    my $queues = '';
-- 
2.30.2

Re: [pve-devel] [PATCH manager 1/3] HDEdit: always show io thread checkbox

[Matthias Heiserer]

On 27.04.2022 14:33, Matthias Heiserer wrote:
> Previously, it was in the advanced section.
> 
> In the qemu wizard, bind iothread to the SCSI controller, so that
> the unlikely/impossible combination of anything other than SCSI-single
> with iothread can't be accidentally selected.
> 
> However, in the guest options, iothread and SCSI controller can still
> be changed independantly.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
Please ignore. Commit message is wrong, and when having more than one 
disk, clicking "io thread" is sychronized among the disks.
Will send a v2