all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: lxc: resources: consider rootfs as a disk again
@ 2022-04-07 12:15 Fabian Ebner
  2022-04-07 13:30 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Ebner @ 2022-04-07 12:15 UTC (permalink / raw)
  To: pve-devel

Commit fa7980c2 ("ui: lxc resources: switch to vector based font
awesome icons") seems like an innocent change, but it broke the
(very brittle) logic here by removing the tdCls for rootfs.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 www/manager6/lxc/Resources.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js
index 683be526..7db55280 100644
--- a/www/manager6/lxc/Resources.js
+++ b/www/manager6/lxc/Resources.js
@@ -263,7 +263,7 @@ Ext.define('PVE.lxc.RessourceView', {
 	    var rowdef = rows[key];
 
 	    var pending = rec.data.delete || me.hasPendingChanges(key);
-	    var isDisk = rowdef.tdCls === 'pve-itype-icon-storage';
+	    let isDisk = key === 'rootfs' || key.match(/^(mp|unused)\d+/);
 	    var isUnusedDisk = key.match(/^unused\d+/);
 	    var isUsedDisk = isDisk && !isUnusedDisk;
 
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] ui: lxc: resources: consider rootfs as a disk again
  2022-04-07 12:15 [pve-devel] [PATCH manager] ui: lxc: resources: consider rootfs as a disk again Fabian Ebner
@ 2022-04-07 13:30 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-04-07 13:30 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fabian Ebner

On 07.04.22 14:15, Fabian Ebner wrote:
> Commit fa7980c2 ("ui: lxc resources: switch to vector based font
> awesome icons") seems like an innocent change, but it broke the
> (very brittle) logic here by removing the tdCls for rootfs.

holy moly, didn't really expect that the gui is using css classes as a state
storage, yuck.

> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  www/manager6/lxc/Resources.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks for catching!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-07 13:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 12:15 [pve-devel] [PATCH manager] ui: lxc: resources: consider rootfs as a disk again Fabian Ebner
2022-04-07 13:30 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal