From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2 2/3] config/node: add 'task_log_max_days' config
Date: Mon, 28 Mar 2022 09:54:18 +0200 [thread overview]
Message-ID: <20220328075419.1020418-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20220328075419.1020418-1-d.csapak@proxmox.com>
to be able to configure the maximum days to keep task logs
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* rebased on master
src/api2/node/config.rs | 4 ++++
src/config/node.rs | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/src/api2/node/config.rs b/src/api2/node/config.rs
index 3b267adc..113d7ed8 100644
--- a/src/api2/node/config.rs
+++ b/src/api2/node/config.rs
@@ -66,6 +66,8 @@ pub enum DeletableProperty {
default_lang,
/// Delete any description
description,
+ /// Delete the task-log-max-days property
+ task_log_max_days,
}
#[api(
@@ -127,6 +129,7 @@ pub fn update_node_config(
DeletableProperty::ciphers_tls_1_2 => { config.ciphers_tls_1_2 = None; },
DeletableProperty::default_lang => { config.default_lang = None; },
DeletableProperty::description => { config.description = None; },
+ DeletableProperty::task_log_max_days => { config.task_log_max_days = None; },
}
}
}
@@ -143,6 +146,7 @@ pub fn update_node_config(
if update.ciphers_tls_1_2.is_some() { config.ciphers_tls_1_2 = update.ciphers_tls_1_2; }
if update.default_lang.is_some() { config.default_lang = update.default_lang; }
if update.description.is_some() { config.description = update.description; }
+ if update.task_log_max_days.is_some() { config.task_log_max_days = update.task_log_max_days; }
crate::config::node::save_config(&config)?;
diff --git a/src/config/node.rs b/src/config/node.rs
index ac6774e3..07e88ee2 100644
--- a/src/config/node.rs
+++ b/src/config/node.rs
@@ -222,6 +222,10 @@ pub struct NodeConfig {
/// Node description
#[serde(skip_serializing_if = "Option::is_none")]
pub description: Option<String>,
+
+ /// Maximum days to keep Task logs
+ #[serde(skip_serializing_if = "Option::is_none")]
+ pub task_log_max_days: Option<usize>,
}
impl NodeConfig {
--
2.30.2
next prev parent reply other threads:[~2022-03-28 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 7:54 [pbs-devel] [PATCH proxmox-backup v2 1/3] rest-server: cleanup_old_tasks: improve error handling Dominik Csapak
2022-03-28 7:54 ` Dominik Csapak [this message]
2022-03-28 7:54 ` [pbs-devel] [PATCH proxmox-backup v2 3/3] rest-server: add option to rotate task logs by 'max_days' instead of 'max_files' Dominik Csapak
2022-04-07 12:06 ` [pbs-devel] applied-series: [PATCH proxmox-backup v2 1/3] rest-server: cleanup_old_tasks: improve error handling Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328075419.1020418-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal