From: Matthias Heiserer <m.heiserer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 5/5 v2] Storage ContentView: Remove dead code
Date: Fri, 18 Mar 2022 14:52:26 +0100 [thread overview]
Message-ID: <20220318135226.2360890-6-m.heiserer@proxmox.com> (raw)
In-Reply-To: <20220318135226.2360890-1-m.heiserer@proxmox.com>
These lines were only used by grid/BackupView, which gets deleted in
this series.
Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
www/manager6/storage/ContentView.js | 22 ++--------------------
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js
index 2874b71e..cb22ab4d 100644
--- a/www/manager6/storage/ContentView.js
+++ b/www/manager6/storage/ContentView.js
@@ -155,20 +155,6 @@ Ext.define('PVE.storage.ContentView', {
renderer: PVE.Utils.render_storage_content,
dataIndex: 'text',
},
- 'notes': {
- header: gettext('Notes'),
- flex: 1,
- renderer: Ext.htmlEncode,
- dataIndex: 'notes',
- },
- 'protected': {
- header: `<i class="fa fa-shield"></i>`,
- tooltip: gettext('Protected'),
- width: 30,
- renderer: v => v ? `<i data-qtip="${gettext('Protected')}" class="fa fa-shield"></i>` : '',
- sorter: (a, b) => (b.data.protected || 0) - (a.data.protected || 0),
- dataIndex: 'protected',
- },
'date': {
header: gettext('Date'),
width: 150,
@@ -194,10 +180,6 @@ Ext.define('PVE.storage.ContentView', {
delete availableColumns[key];
}
});
-
- if (me.extraColumns && typeof me.extraColumns === 'object') {
- Object.assign(availableColumns, me.extraColumns);
- }
const columns = Object.values(availableColumns);
Ext.apply(me, {
@@ -216,8 +198,8 @@ Ext.define('PVE.storage.ContentView', {
Ext.define('pve-storage-content', {
extend: 'Ext.data.Model',
fields: [
- 'volid', 'content', 'format', 'size', 'used', 'vmid',
- 'channel', 'id', 'lun', 'notes', 'verification',
+ 'volid', 'content', 'format', 'size', 'used',
+ 'channel', 'id', 'lun',
{
name: 'text',
convert: function(value, record) {
--
2.30.2
next prev parent reply other threads:[~2022-03-18 13:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 13:52 [pve-devel] [PATCH manager 0/5 v2] BackupView as TreePanel Matthias Heiserer
2022-03-18 13:52 ` [pve-devel] [PATCH manager 1/5 v2] Storage GUI: Rewrite backup content view " Matthias Heiserer
2022-03-22 8:42 ` Fabian Ebner
2022-03-22 12:38 ` Thomas Lamprecht
2022-03-30 12:59 ` Matthias Heiserer
2022-03-31 6:36 ` Fabian Ebner
2022-03-31 6:56 ` Thomas Lamprecht
2022-03-18 13:52 ` [pve-devel] [PATCH manager 2/5 v2] GUI: Utils: Helpers for backup type and icon Matthias Heiserer
2022-03-18 14:51 ` Thomas Lamprecht
2022-03-18 13:52 ` [pve-devel] [PATCH manager 3/5 v2] Backup GUI: Use the new storage/BackupView instead of grid/BackupView Matthias Heiserer
2022-03-22 8:47 ` Fabian Ebner
2022-03-18 13:52 ` [pve-devel] [PATCH manager 4/5 v2] Remove grid/backupview as it got replaced by storage/backupview Matthias Heiserer
2022-03-22 8:47 ` Fabian Ebner
2022-03-18 13:52 ` Matthias Heiserer [this message]
2022-03-22 8:48 ` [pve-devel] [PATCH manager 5/5 v2] Storage ContentView: Remove dead code Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318135226.2360890-6-m.heiserer@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.