From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager 1/3] fix #3903: jobs-plugin: add remove vmid from jobs helper
Date: Tue, 1 Mar 2022 08:51:51 +0000 [thread overview]
Message-ID: <20220301085153.31445-2-h.laimer@proxmox.com> (raw)
In-Reply-To: <20220301085153.31445-1-h.laimer@proxmox.com>
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
PVE/Jobs/Plugin.pm | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/PVE/Jobs/Plugin.pm b/PVE/Jobs/Plugin.pm
index 6098360b..4883a193 100644
--- a/PVE/Jobs/Plugin.pm
+++ b/PVE/Jobs/Plugin.pm
@@ -3,7 +3,7 @@ package PVE::Jobs::Plugin;
use strict;
use warnings;
-use PVE::Cluster qw(cfs_register_file);
+use PVE::Cluster qw(cfs_register_file cfs_lock_file cfs_read_file cfs_write_file);
use base qw(PVE::SectionConfig);
@@ -92,6 +92,23 @@ sub write_config {
$class->SUPER::write_config($filename, $cfg);
}
+sub remove_vmid_from_jobs {
+ my ($vmid) = @_;
+ cfs_lock_file('jobs.cfg', undef, sub {
+ my $jobs_data = cfs_read_file('jobs.cfg');
+ while((my $id, my $job) = each (%{$jobs_data->{ids}})){
+ next if !defined($job->{vmid});
+ $job->{vmid} = join(',', grep { $_ ne $vmid } PVE::Tools::split_list($job->{vmid}));
+ if ($job->{vmid} eq '') {
+ delete $jobs_data->{ids}->{$id};
+ } else {
+ $jobs_data->{ids}->{$id} = $job;
+ }
+ }
+ cfs_write_file('jobs.cfg', $jobs_data);
+ });
+}
+
sub run {
my ($class, $cfg) = @_;
# implement in subclass
--
2.30.2
next prev parent reply other threads:[~2022-03-01 8:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 8:51 [pve-devel] [PATCH-SERIES] fix #3903: remove vmid from jobs.cfg on destroy Hannes Laimer
2022-03-01 8:51 ` Hannes Laimer [this message]
2022-03-02 10:12 ` [pve-devel] [PATCH pve-manager 1/3] fix #3903: jobs-plugin: add remove vmid from jobs helper Fabian Ebner
2022-03-01 8:51 ` [pve-devel] [PATCH pve-container 2/3] fix #3903: api2: remove vmid from jobs.cfg Hannes Laimer
2022-03-02 10:16 ` Fabian Ebner
2022-03-02 14:28 ` Hannes Laimer
2022-03-03 9:08 ` Fabian Ebner
2022-03-01 8:51 ` [pve-devel] [PATCH qemu-server 3/3] " Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301085153.31445-2-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.