From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-zsync 1/2] rename encode_cron to parse_cron
Date: Mon, 21 Feb 2022 10:07:49 +0100 [thread overview]
Message-ID: <20220221090750.17598-1-f.ebner@proxmox.com> (raw)
The old name is confusing, because "encode" is usually not used when
converting from text to a data structure.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
pve-zsync | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pve-zsync b/pve-zsync
index b466076..7246336 100755
--- a/pve-zsync
+++ b/pve-zsync
@@ -232,7 +232,7 @@ sub read_cron {
my $text = read_file($CRONJOBS, 0);
- return encode_cron(@{$text});
+ return parse_cron(@{$text});
}
sub parse_argv {
@@ -302,7 +302,7 @@ sub add_state_to_job {
return $job;
}
-sub encode_cron {
+sub parse_cron {
my (@text) = @_;
my $cfg = {};
--
2.30.2
next reply other threads:[~2022-02-21 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 9:07 Fabian Ebner [this message]
2022-02-21 9:07 ` [pve-devel] [PATCH pve-zsync 2/2] parse cron: handle additional whitespace Fabian Ebner
2022-02-21 15:05 ` Thomas Lamprecht
2022-02-21 15:06 ` [pve-devel] applied: [PATCH pve-zsync 1/2] rename encode_cron to parse_cron Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221090750.17598-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.