From: Oguz Bektas <o.bektas@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 manager] ui: vm network: allow to override MTU for virtio devices
Date: Thu, 10 Feb 2022 12:28:36 +0100 [thread overview]
Message-ID: <20220210112836.616619-1-o.bektas@proxmox.com> (raw)
we already have the 'mtu' option inside the API, so we can just expose
that option inside the 'Advanced' menu for virtio network interfaces.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
v1->v2:
* add viewmodel formula 'isVirtio', we use it to set the MTU field
enabled only for virtio interfaces
www/manager6/qemu/NetworkEdit.js | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
index b39cffdc..1e34ad1c 100644
--- a/www/manager6/qemu/NetworkEdit.js
+++ b/www/manager6/qemu/NetworkEdit.js
@@ -19,6 +19,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
me.network.macaddr = values.macaddr;
me.network.disconnect = values.disconnect;
me.network.queues = values.queues;
+ me.network.mtu = values.mtu;
if (values.rate) {
me.network.rate = values.rate;
@@ -33,6 +34,16 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
return params;
},
+ viewModel: {
+ data: {
+ network_model: '',
+ },
+ formulas: {
+ isVirtio: (get) => get('network_model') === 'virtio',
+ },
+ },
+
+
setNetwork: function(confid, data) {
var me = this;
@@ -55,6 +66,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
me.bridgesel.setNodename(nodename);
},
+
initComponent: function() {
var me = this;
@@ -112,6 +124,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
'macaddr',
'rate',
'queues',
+ 'mtu',
];
fields.forEach(function(fieldname) {
me.down('field[name='+fieldname+']').setDisabled(value);
@@ -125,11 +138,13 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
});
}
+
me.column2.push(
{
xtype: 'pveNetworkCardSelector',
name: 'model',
fieldLabel: gettext('Model'),
+ bind: '{network_model}',
value: PVE.qemu.OSDefaults.generic.networkCard,
allowBlank: false,
},
@@ -161,6 +176,16 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
value: '',
allowBlank: true,
},
+ {
+ xtype: 'proxmoxintegerfield',
+ name: 'mtu',
+ fieldLabel: 'MTU',
+ value: '',
+ bind: {
+ disabled: '{!isVirtio}',
+ },
+ allowBlank: true,
+ },
];
me.callParent();
--
2.30.2
next reply other threads:[~2022-02-10 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 11:28 Oguz Bektas [this message]
2022-02-10 13:53 ` Aaron Lauterer
2022-02-10 13:55 ` Aaron Lauterer
2022-02-10 14:08 ` Oguz Bektas
2022-02-10 14:14 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220210112836.616619-1-o.bektas@proxmox.com \
--to=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.