From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-common 1/4] read_proc_stat : initialize newer fields to 0
Date: Mon, 10 Jan 2022 05:52:57 +0100 [thread overview]
Message-ID: <20220110045300.3668895-2-aderumier@odiso.com> (raw)
In-Reply-To: <20220110045300.3668895-1-aderumier@odiso.com>
new fields has been added recently, but values are not initialized
https://git.proxmox.com/?p=pve-common.git;a=commit;h=5a82eb712e4c879a271686f07c589fadc0b09185
as total of all fields is compute later, this can give undef values
---
src/PVE/ProcFSTools.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/ProcFSTools.pm b/src/PVE/ProcFSTools.pm
index a75274a..c816131 100644
--- a/src/PVE/ProcFSTools.pm
+++ b/src/PVE/ProcFSTools.pm
@@ -162,7 +162,7 @@ sub read_pressure {
my $last_proc_stat;
sub read_proc_stat {
- my $res = { user => 0, nice => 0, system => 0, idle => 0 , sum => 0};
+ my $res = { user => 0, nice => 0, system => 0, idle => 0 , iowait => 0, irq => 0, softirq => 0, steal => 0, guest => 0, guest_nice => 0, sum => 0};
my $cpucount = 0;
--
2.30.2
next prev parent reply other threads:[~2022-01-10 4:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 4:52 [pve-devel] [PATCH pve-common 0/4] improve host read_proc_stat Alexandre Derumier
2022-01-10 4:52 ` Alexandre Derumier [this message]
2022-01-10 4:52 ` [pve-devel] [PATCH pve-common 2/4] read_proc_stat: substract guest && guest_nice from user && nice time Alexandre Derumier
2022-01-10 4:52 ` [pve-devel] [PATCH pve-common 3/4] read_proc_stat: add irq/softirq/steal to total used cpu Alexandre Derumier
2022-01-10 4:53 ` [pve-devel] [PATCH pve-common 4/4] read_proc_stat: use total of fields to compute percentage Alexandre Derumier
2022-01-13 15:33 ` [pve-devel] applied-series: [PATCH pve-common 0/4] improve host read_proc_stat Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220110045300.3668895-2-aderumier@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.