* [pve-devel] [PATCH login-manager] fix colors for tfa dialog
@ 2021-12-20 11:35 Dominik Csapak
2021-12-20 13:53 ` Aaron Lauterer
2021-12-20 19:50 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2021-12-20 11:35 UTC (permalink / raw)
To: pve-devel
with the recent changes, the input field was invisible, adapting
like the login dialog
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
lib/proxmox_tfa_form.dart | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/proxmox_tfa_form.dart b/lib/proxmox_tfa_form.dart
index db3cfa7..3743455 100644
--- a/lib/proxmox_tfa_form.dart
+++ b/lib/proxmox_tfa_form.dart
@@ -17,9 +17,12 @@ class _ProxmoxTfaFormState extends State<ProxmoxTfaForm> {
@override
Widget build(BuildContext context) {
return Theme(
- data: ThemeData.dark().copyWith(accentColor: Color(0xFFE47225)),
+ data: ThemeData.dark().copyWith(
+ colorScheme: ColorScheme.dark().copyWith(
+ secondary: ProxmoxColors.orange,
+ onSecondary: ProxmoxColors.supportGrey)),
child: Scaffold(
- backgroundColor: Theme.of(context).primaryColor,
+ backgroundColor: ProxmoxColors.supportBlue,
extendBodyBehindAppBar: true,
appBar: AppBar(
elevation: 0.0,
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pve-devel] [PATCH login-manager] fix colors for tfa dialog
2021-12-20 11:35 [pve-devel] [PATCH login-manager] fix colors for tfa dialog Dominik Csapak
@ 2021-12-20 13:53 ` Aaron Lauterer
2021-12-20 19:50 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Aaron Lauterer @ 2021-12-20 13:53 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
Seems to work fine.
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 12/20/21 12:35, Dominik Csapak wrote:
> with the recent changes, the input field was invisible, adapting
> like the login dialog
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> lib/proxmox_tfa_form.dart | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/proxmox_tfa_form.dart b/lib/proxmox_tfa_form.dart
> index db3cfa7..3743455 100644
> --- a/lib/proxmox_tfa_form.dart
> +++ b/lib/proxmox_tfa_form.dart
> @@ -17,9 +17,12 @@ class _ProxmoxTfaFormState extends State<ProxmoxTfaForm> {
> @override
> Widget build(BuildContext context) {
> return Theme(
> - data: ThemeData.dark().copyWith(accentColor: Color(0xFFE47225)),
> + data: ThemeData.dark().copyWith(
> + colorScheme: ColorScheme.dark().copyWith(
> + secondary: ProxmoxColors.orange,
> + onSecondary: ProxmoxColors.supportGrey)),
> child: Scaffold(
> - backgroundColor: Theme.of(context).primaryColor,
> + backgroundColor: ProxmoxColors.supportBlue,
> extendBodyBehindAppBar: true,
> appBar: AppBar(
> elevation: 0.0,
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] applied: [PATCH login-manager] fix colors for tfa dialog
2021-12-20 11:35 [pve-devel] [PATCH login-manager] fix colors for tfa dialog Dominik Csapak
2021-12-20 13:53 ` Aaron Lauterer
@ 2021-12-20 19:50 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2021-12-20 19:50 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 20/12/2021 12:35, Dominik Csapak wrote:
> with the recent changes, the input field was invisible, adapting
> like the login dialog
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> lib/proxmox_tfa_form.dart | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
applied with Aaron's T-b, thanks!
I adapted the commit message slightly though, as this is not a real fix
but just using the same stop-gap measurement I did for the main login
form..
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-20 19:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 11:35 [pve-devel] [PATCH login-manager] fix colors for tfa dialog Dominik Csapak
2021-12-20 13:53 ` Aaron Lauterer
2021-12-20 19:50 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal