Re: [pbs-devel] [PATCH proxmox-backup 6/6] api: add metricserver endpoints

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

On Tue, Dec 14, 2021 at 01:24:12PM +0100, Dominik Csapak wrote:
> but in contrast to pve, we split the api by type of the section config,
> since we cannot handle multiple types in the updater
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> +
> +#[api()]
> +#[derive(Serialize, Deserialize)]
> +#[serde(rename_all="kebab-case")]
> +#[allow(non_camel_case_types)]
           ^~~~~~~~~~~~~~~~~~~^

Please don't add more of this nonsense!

> +/// Deletable property name
> +pub enum DeletableProperty {
> +    /// Delete the port property.
> +    port,
> +    /// Delete the https property.
> +    https,
> +    /// Delete the token property.
> +    token,
> +    /// Delete the bucket property.
> +    bucket,
> +    /// Delete the organization property.
> +    organization,
> +    /// Delete the max_body_size property.
> +    max_body_size,
> +    /// Delete the verify_tls property.
> +    verify_tls,
> +    /// Delete the comment property.
> +    comment,
> +}


> +#[api()]
> +#[derive(Serialize, Deserialize)]
> +#[serde(rename_all="kebab-case")]
> +#[allow(non_camel_case_types)]

No

> +/// Deletable property name
> +pub enum DeletableProperty {
> +    /// Delete the mtu property.
> +    mtu,
> +    /// Delete the comment property.
> +    comment,
> +}
> +