all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui] sorters: use correct property 'direction' and keep default 'ASC'
Date: Tue,  7 Dec 2021 12:53:31 +0100	[thread overview]
Message-ID: <20211207115331.67545-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20211207115331.67545-1-f.ebner@proxmox.com>

Ext.util.Sorter does not have an 'order' property, so 'order: DESC'
didn't have an effect. The default is 'ASC' and it is arguably the
preferred direction for all affected sorters anyways.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 js/ActionList.js               | 2 +-
 js/ClamAVDatabase.js           | 2 +-
 js/LDAPConfig.js               | 2 +-
 js/MailProxyTLSDestinations.js | 2 +-
 js/MyNetworks.js               | 2 +-
 js/ObjectGroupList.js          | 2 +-
 js/PBSConfig.js                | 2 +-
 js/RelayDomains.js             | 2 +-
 js/SpamDetectorStatus.js       | 2 +-
 js/Transport.js                | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/js/ActionList.js b/js/ActionList.js
index bb13a5b..a94e3e1 100644
--- a/js/ActionList.js
+++ b/js/ActionList.js
@@ -31,7 +31,7 @@ Ext.define('PMG.ActionList', {
 	    },
 	    sorters: {
 		property: 'name',
-		order: 'DESC',
+		direction: 'ASC',
 	    },
 	});
 
diff --git a/js/ClamAVDatabase.js b/js/ClamAVDatabase.js
index 884ffe1..d3f8e49 100644
--- a/js/ClamAVDatabase.js
+++ b/js/ClamAVDatabase.js
@@ -66,7 +66,7 @@ Ext.define('PMG.ClamAVDatabaseStatus', {
 	    },
 	    sorters: {
 		property: 'name',
-		order: 'DESC',
+		direction: 'ASC',
 	    },
 	});
 
diff --git a/js/LDAPConfig.js b/js/LDAPConfig.js
index d7e4263..0a114ff 100644
--- a/js/LDAPConfig.js
+++ b/js/LDAPConfig.js
@@ -518,7 +518,7 @@ Ext.define('PMG.LDAPConfigGrid', {
 	model: 'pmg-ldap-config',
 	sorters: [{
 	    property: 'profile',
-	    order: 'DESC',
+	    direction: 'ASC',
 	}],
     },
 
diff --git a/js/MailProxyTLSDestinations.js b/js/MailProxyTLSDestinations.js
index 0bdcc2a..04348c9 100644
--- a/js/MailProxyTLSDestinations.js
+++ b/js/MailProxyTLSDestinations.js
@@ -8,7 +8,7 @@ Ext.define('pmg-tls-policy', {
     },
     sorters: {
 	property: 'destination',
-	order: 'DESC',
+	direction: 'ASC',
     },
 });
 
diff --git a/js/MyNetworks.js b/js/MyNetworks.js
index 6c52f1a..975e21d 100644
--- a/js/MyNetworks.js
+++ b/js/MyNetworks.js
@@ -19,7 +19,7 @@ Ext.define('PMG.MyNetworks', {
 	    model: 'pmg-mynetworks',
 	    sorters: {
 		property: 'cidr',
-		order: 'DESC',
+		direction: 'ASC',
 	    },
 	});
 
diff --git a/js/ObjectGroupList.js b/js/ObjectGroupList.js
index 2e850e6..80dedc9 100644
--- a/js/ObjectGroupList.js
+++ b/js/ObjectGroupList.js
@@ -88,7 +88,7 @@ Ext.define('PMG.ObjectGroupList', {
 	    },
 	    sorters: {
 		property: 'name',
-		order: 'DESC',
+		direction: 'ASC',
 	    },
 	});
 
diff --git a/js/PBSConfig.js b/js/PBSConfig.js
index 5e88574..3f09ccc 100644
--- a/js/PBSConfig.js
+++ b/js/PBSConfig.js
@@ -103,7 +103,7 @@ Ext.define('PMG.PBSConfigGrid', {
 	model: 'pmg-pbs-config',
 	sorters: [{
 	    property: 'remote',
-	    order: 'DESC',
+	    direction: 'ASC',
 	}],
     },
 
diff --git a/js/RelayDomains.js b/js/RelayDomains.js
index 0098e20..ec43aa1 100644
--- a/js/RelayDomains.js
+++ b/js/RelayDomains.js
@@ -20,7 +20,7 @@ Ext.define('PMG.RelayDomains', {
 	    model: 'pmg-domains',
 	    sorters: {
 		property: 'domain',
-		order: 'DESC',
+		direction: 'ASC',
 	    },
 	    proxy: {
 		type: 'proxmox',
diff --git a/js/SpamDetectorStatus.js b/js/SpamDetectorStatus.js
index 4b6d0fb..a0da9ff 100644
--- a/js/SpamDetectorStatus.js
+++ b/js/SpamDetectorStatus.js
@@ -94,7 +94,7 @@ Ext.define('PMG.SpamDetectorStatusGrid', {
 	    },
 	    sorters: {
 		property: 'name',
-		order: 'DESC',
+		direction: 'ASC',
 	    },
 	});
 
diff --git a/js/Transport.js b/js/Transport.js
index 97a4aad..141fde1 100644
--- a/js/Transport.js
+++ b/js/Transport.js
@@ -20,7 +20,7 @@ Ext.define('PMG.Transport', {
 	    model: 'pmg-transport',
 	    sorters: {
 		property: 'domain',
-		order: 'DESC',
+		direction: 'ASC',
 	    },
 	});
 	Proxmox.Utils.monStoreErrors(me, store, true);
-- 
2.30.2





  reply	other threads:[~2021-12-07 12:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07 11:53 [pmg-devel] [PATCH widget-toolkit] " Fabian Ebner
2021-12-07 11:53 ` Fabian Ebner [this message]
2022-02-03 11:33   ` [pmg-devel] applied: [PATCH pmg-gui] " Thomas Lamprecht
2022-02-10 12:56 ` [pmg-devel] applied: [PATCH widget-toolkit] " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211207115331.67545-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal