all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH widget-toolkit] sorters: use correct property 'direction' and keep default 'ASC'
Date: Tue,  7 Dec 2021 12:53:30 +0100	[thread overview]
Message-ID: <20211207115331.67545-1-f.ebner@proxmox.com> (raw)

Ext.util.Sorter does not have an 'order' property, so 'order: DESC'
didn't have an effect. The default is 'ASC' and it is arguably the
preferred direction for realm anyways.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---

I'll also send a patch for PVE later. PBS doesn't have this mistake
anywhere AFAICS.

 src/panel/AuthView.js     | 2 +-
 src/window/ACMEAccount.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/panel/AuthView.js b/src/panel/AuthView.js
index 781e84e..69fe1a5 100644
--- a/src/panel/AuthView.js
+++ b/src/panel/AuthView.js
@@ -39,7 +39,7 @@ Ext.define('Proxmox.panel.AuthView', {
 	model: 'pmx-domains',
 	sorters: {
 	    property: 'realm',
-	    order: 'DESC',
+	    direction: 'ASC',
 	},
     },
 
diff --git a/src/window/ACMEAccount.js b/src/window/ACMEAccount.js
index 05278a8..cf16736 100644
--- a/src/window/ACMEAccount.js
+++ b/src/window/ACMEAccount.js
@@ -45,7 +45,7 @@ Ext.define('Proxmox.window.ACMEAccountCreate', {
 		proxy: { type: 'proxmox' },
 		sorters: {
 		    property: 'name',
-		    order: 'ASC',
+		    direction: 'ASC',
 		},
 	    },
 	    listConfig: {
-- 
2.30.2





             reply	other threads:[~2021-12-07 12:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07 11:53 Fabian Ebner [this message]
2021-12-07 11:53 ` [pmg-devel] [PATCH pmg-gui] " Fabian Ebner
2022-02-03 11:33   ` [pmg-devel] applied: " Thomas Lamprecht
2022-02-10 12:56 ` [pmg-devel] applied: [PATCH widget-toolkit] " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211207115331.67545-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal