all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH guest-common/manager] log id and schedule in backup job task
Date: Fri,  3 Dec 2021 14:35:06 +0100	[thread overview]
Message-ID: <20211203133508.925393-1-d.csapak@proxmox.com> (raw)

by adding a generic 'logcomment' paramter and using it through the
jobs plugin

the patch in guest-common is only to filter it out when printing the
command line

(maybe we want a better name than 'logcomment' for the parameter though...)

pve-guest-common:

Dominik Csapak (1):
  vzdump: skip 'logcomment' param for command_line

 src/PVE/VZDump/Common.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

pve-manager:

Dominik Csapak (1):
  vzdump: add 'logcomment' parameter

 PVE/API2/VZDump.pm | 6 ++++++
 PVE/Jobs.pm        | 2 +-
 PVE/Jobs/VZDump.pm | 3 ++-
 PVE/VZDump.pm      | 5 +++++
 4 files changed, 14 insertions(+), 2 deletions(-)

-- 
2.30.2





             reply	other threads:[~2021-12-03 13:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 13:35 Dominik Csapak [this message]
2021-12-03 13:35 ` [pve-devel] [PATCH guest-common 1/1] vzdump: skip 'logcomment' param for command_line Dominik Csapak
2021-12-03 13:35 ` [pve-devel] [PATCH manager 1/1] vzdump: add 'logcomment' parameter Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211203133508.925393-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal