* [pve-devel] [PATCH installer] proxmox-boot-preparation: add newline to /etc/kernel/cmdline
@ 2021-11-30 17:52 Stoiko Ivanov
2021-12-01 8:06 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Stoiko Ivanov @ 2021-11-30 17:52 UTC (permalink / raw)
To: pve-devel
for better readability - and more robust handling in proxmox-boot-tool
quickly tested with the latest PMG-ISO and the debug mode.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
proxinstall | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index ddb4523..ae0e235 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1789,7 +1789,7 @@ _EOD
my $zfs_snippet = "GRUB_CMDLINE_LINUX=\"\$GRUB_CMDLINE_LINUX root=ZFS=$zfspoolname/ROOT/$zfsrootvolname boot=zfs\"";
write_config($zfs_snippet, "$targetdir/etc/default/grub.d/zfs.cfg");
- write_config("root=ZFS=$zfspoolname/ROOT/$zfsrootvolname boot=zfs", "$targetdir/etc/kernel/cmdline");
+ write_config("root=ZFS=$zfspoolname/ROOT/$zfsrootvolname boot=zfs\n", "$targetdir/etc/kernel/cmdline");
}
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH installer] proxmox-boot-preparation: add newline to /etc/kernel/cmdline
2021-11-30 17:52 [pve-devel] [PATCH installer] proxmox-boot-preparation: add newline to /etc/kernel/cmdline Stoiko Ivanov
@ 2021-12-01 8:06 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-12-01 8:06 UTC (permalink / raw)
To: Proxmox VE development discussion, Stoiko Ivanov
On 30.11.21 18:52, Stoiko Ivanov wrote:
> for better readability - and more robust handling in proxmox-boot-tool
>
> quickly tested with the latest PMG-ISO and the debug mode.
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> proxinstall | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-01 8:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-30 17:52 [pve-devel] [PATCH installer] proxmox-boot-preparation: add newline to /etc/kernel/cmdline Stoiko Ivanov
2021-12-01 8:06 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal