* [pve-devel] [PATCH widget-toolkit] data: diffstore: fix autoDestroyRstore option
@ 2021-11-18 9:50 Dominik Csapak
2021-11-18 10:17 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-11-18 9:50 UTC (permalink / raw)
To: pve-devel
the change from extjs 6.0.1 to 7.0.0 removed 'onDestroy' but brought
us 'doDestroy' for stores
we did not notice since 'onDestroy' was a private method and thus
the changelog did not mention this (doDestroy is a public method meant
exactly for our use case)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/data/DiffStore.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/data/DiffStore.js b/src/data/DiffStore.js
index e4143f5..935bc11 100644
--- a/src/data/DiffStore.js
+++ b/src/data/DiffStore.js
@@ -28,7 +28,7 @@ Ext.define('Proxmox.data.DiffStore', {
// config is passed instead of an existing rstore instance
autoDestroyRstore: false,
- onDestroy: function() {
+ doDestroy: function() {
let me = this;
if (me.autoDestroyRstore) {
if (Ext.isFunction(me.rstore.destroy)) {
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH widget-toolkit] data: diffstore: fix autoDestroyRstore option
2021-11-18 9:50 [pve-devel] [PATCH widget-toolkit] data: diffstore: fix autoDestroyRstore option Dominik Csapak
@ 2021-11-18 10:17 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-11-18 10:17 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 18.11.21 10:50, Dominik Csapak wrote:
> the change from extjs 6.0.1 to 7.0.0 removed 'onDestroy' but brought
> us 'doDestroy' for stores
>
> we did not notice since 'onDestroy' was a private method and thus
> the changelog did not mention this (doDestroy is a public method meant
> exactly for our use case)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/data/DiffStore.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-18 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18 9:50 [pve-devel] [PATCH widget-toolkit] data: diffstore: fix autoDestroyRstore option Dominik Csapak
2021-11-18 10:17 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal