all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [RFC proxmox-backup v3 0/2] more flexible HumanByte type
Date: Thu, 18 Nov 2021 08:29:20 +0100	[thread overview]
Message-ID: <20211118072922.2233682-1-dietmar@proxmox.com> (raw)

Changes since v2:

 - reverted changes from v2

 - restrict number of possibleunits (always store KB instead of K)
 
 - store size without scaling to unit (avoid rounding errors in
   deserialze/serialze)

 - allow to specify precision in Display

 - new with_unit() constructor

 - improved dev docs

Changes since v1:

- do not expose auto_unit functions
- store size as u64 (suggested by thomas)
- do not store unit (suggested by thomas)


*** BLURB HERE ***

Dietmar Maurer (2):
  pbs-api-types: more flexible HumanByte type
  use HumanByte for traffic-control config

 pbs-api-types/src/human_byte.rs      | 353 +++++++++++++++++++++++++++
 pbs-api-types/src/lib.rs             |   3 +
 pbs-api-types/src/traffic_control.rs |  18 +-
 pbs-client/src/backup_writer.rs      |  19 +-
 pbs-datastore/src/datastore.rs       |  13 +-
 pbs-tools/Cargo.toml                 |   1 +
 pbs-tools/src/format.rs              |  55 +----
 src/bin/proxmox-tape.rs              |   7 +-
 src/cached_traffic_control.rs        |  18 +-
 src/server/email_notifications.rs    |   5 +-
 10 files changed, 403 insertions(+), 89 deletions(-)
 create mode 100644 pbs-api-types/src/human_byte.rs

-- 
2.30.2





             reply	other threads:[~2021-11-18  7:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18  7:29 Dietmar Maurer [this message]
2021-11-18  7:29 ` [pbs-devel] [RFC proxmox-backup v3 1/2] pbs-api-types: " Dietmar Maurer
2021-11-20 21:55   ` Thomas Lamprecht
2021-11-18  7:29 ` [pbs-devel] [RFC proxmox-backup v3 2/2] use HumanByte for traffic-control config Dietmar Maurer
2021-11-20 21:55   ` [pbs-devel] applied: " Thomas Lamprecht
2021-11-18  9:28 ` [pbs-devel] [RFC proxmox-backup v3 0/2] more flexible HumanByte type Fabian Ebner
2021-11-19 12:48 Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211118072922.2233682-1-dietmar@proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal