From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 2/2] cifs: check connection: bubble up NT_STATUS_LOGON_FAILURE
Date: Mon, 15 Nov 2021 13:37:56 +0100 [thread overview]
Message-ID: <20211115123756.146659-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20211115123756.146659-1-f.ebner@proxmox.com>
in the same manner as NT_STATUS_ACCESS_DENIED. It can be assumed to be
a configuration error, so avoid showing the generic "storage <storeid>
is not online". Reported in the community forum:
https://forum.proxmox.com/threads/storage-is-not-online-cifs.99201/post-428858
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/Storage/CIFSPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm
index a3f9ebe..d5efa5f 100644
--- a/PVE/Storage/CIFSPlugin.pm
+++ b/PVE/Storage/CIFSPlugin.pm
@@ -280,7 +280,7 @@ sub check_connection {
if (my $err = $@) {
die "$out_str\n" if defined($out_str) &&
- ($out_str =~ m/NT_STATUS_ACCESS_DENIED/);
+ ($out_str =~ m/NT_STATUS_(ACCESS_DENIED|LOGON_FAILURE)/);
return 0;
}
--
2.30.2
next prev parent reply other threads:[~2021-11-15 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 12:37 [pve-devel] [PATCH storage 1/2] activate storage: improve error when check_connection dies Fabian Ebner
2021-11-15 12:37 ` Fabian Ebner [this message]
2022-03-16 16:37 ` [pve-devel] applied: [PATCH storage 2/2] cifs: check connection: bubble up NT_STATUS_LOGON_FAILURE Thomas Lamprecht
2022-03-16 16:37 ` [pve-devel] applied: [PATCH storage 1/2] activate storage: improve error when check_connection dies Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115123756.146659-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal