* [pve-devel] [PATCH widget-toolkit] window/TfaWindow: fix text format
@ 2021-11-12 14:40 Dominik Csapak
2021-11-12 15:14 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-11-12 14:40 UTC (permalink / raw)
To: pve-devel
Ext.String.format was missing to show the number correctly
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
alternatively, we could simply change the gettext, but
this way we are more flexible if we want to change the number in the
future
src/window/TfaWindow.js | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/window/TfaWindow.js b/src/window/TfaWindow.js
index d568f9b..27d53f0 100644
--- a/src/window/TfaWindow.js
+++ b/src/window/TfaWindow.js
@@ -384,7 +384,10 @@ Ext.define('Proxmox.window.TfaLoginWindow', {
reference: 'recoveryLow',
hidden: true,
html: '<i class="fa fa-exclamation-triangle warning"></i>'
- + gettext('Less than {0} recovery keys available. Please generate a new set after login!'),
+ + Ext.String.format(
+ gettext('Less than {0} recovery keys available. Please generate a new set after login!'),
+ 4,
+ ),
},
],
},
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH widget-toolkit] window/TfaWindow: fix text format
2021-11-12 14:40 [pve-devel] [PATCH widget-toolkit] window/TfaWindow: fix text format Dominik Csapak
@ 2021-11-12 15:14 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-11-12 15:14 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 12.11.21 15:40, Dominik Csapak wrote:
> Ext.String.format was missing to show the number correctly
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> alternatively, we could simply change the gettext, but
> this way we are more flexible if we want to change the number in the
> future
> src/window/TfaWindow.js | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-12 15:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 14:40 [pve-devel] [PATCH widget-toolkit] window/TfaWindow: fix text format Dominik Csapak
2021-11-12 15:14 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal