all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/4] ui: qm: disk selection: add optional selection of unused
Date: Fri, 12 Nov 2021 10:53:32 +0100	[thread overview]
Message-ID: <20211112095335.1839765-2-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20211112095335.1839765-1-a.lauterer@proxmox.com>

With this optional setting, it is possible to allow the user to also
select 'unused' as a disk bus type.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 www/manager6/Utils.js                   | 1 +
 www/manager6/form/BusTypeSelector.js    | 5 +++++
 www/manager6/form/ControllerSelector.js | 2 ++
 3 files changed, 8 insertions(+)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 274d4db2..1aaa5085 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1548,6 +1548,7 @@ Ext.define('PVE.Utils', {
 	sata: 6,
 	scsi: 31,
 	virtio: 16,
+	unused: 256,
     },
 
     // types is either undefined (all busses), an array of busses, or a single bus
diff --git a/www/manager6/form/BusTypeSelector.js b/www/manager6/form/BusTypeSelector.js
index 13027f5a..a420e56f 100644
--- a/www/manager6/form/BusTypeSelector.js
+++ b/www/manager6/form/BusTypeSelector.js
@@ -3,6 +3,7 @@ Ext.define('PVE.form.BusTypeSelector', {
     alias: 'widget.pveBusSelector',
 
     noVirtIO: false,
+    withUnused: false,
 
     initComponent: function() {
 	var me = this;
@@ -15,6 +16,10 @@ Ext.define('PVE.form.BusTypeSelector', {
 
 	me.comboItems.push(['scsi', 'SCSI']);
 
+	if (me.withUnused) {
+	    me.comboItems.push(['unused', 'Unused']);
+	}
+
 	me.callParent();
     },
 });
diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js
index 71332db5..798dc4b2 100644
--- a/www/manager6/form/ControllerSelector.js
+++ b/www/manager6/form/ControllerSelector.js
@@ -3,6 +3,7 @@ Ext.define('PVE.form.ControllerSelector', {
     alias: 'widget.pveControllerSelector',
 
     noVirtIO: false,
+    withUnused: false,
 
     vmconfig: {}, // used to check for existing devices
 
@@ -73,6 +74,7 @@ Ext.define('PVE.form.ControllerSelector', {
 		    itemId: 'controller',
 		    value: PVE.qemu.OSDefaults.generic.busType,
 		    noVirtIO: me.noVirtIO,
+		    withUnused: me.withUnused,
 		    allowBlank: false,
 		    flex: 2,
 		    listeners: {
-- 
2.30.2





  reply	other threads:[~2021-11-12  9:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12  9:53 [pve-devel] [PATCH manager 0/4] ui: lxc/qemu: add reassign for disks and Aaron Lauterer
2021-11-12  9:53 ` Aaron Lauterer [this message]
2021-11-12 17:39   ` [pve-devel] applied: [PATCH manager 1/4] ui: qm: disk selection: add optional selection of unused Thomas Lamprecht
2021-11-12  9:53 ` [pve-devel] [PATCH manager 2/4] ui: lxc/qemu: add disk reassign Aaron Lauterer
2021-11-12  9:53 ` [pve-devel] [PATCH manager 3/4] ui: BusTypeSelector: change noVirtIO to withVirtIO Aaron Lauterer
2021-11-12  9:53 ` [pve-devel] [PATCH manager 4/4] ui: hdmove: modernize/refactor Aaron Lauterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211112095335.1839765-2-a.lauterer@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal