From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/5] ui: dc/Backup: never show id input field, autogenerate id
Date: Thu, 11 Nov 2021 12:07:05 +0100 [thread overview]
Message-ID: <20211111110709.633855-5-d.csapak@proxmox.com> (raw)
In-Reply-To: <20211111110709.633855-1-d.csapak@proxmox.com>
similar to pbs sync jobs
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/dc/Backup.js | 22 ++++------------------
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index e33f5e27..3f250a76 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -176,24 +176,6 @@ Ext.define('PVE.dc.BackupEdit', {
});
let column1 = [
- {
- xtype: 'pmxDisplayEditField',
- name: 'id',
- fieldLabel: gettext('ID'),
- renderer: Ext.htmlEncode,
- fieldStyle: me.isCreate ? {} : {
- 'text-overflow': 'ellipsis',
- 'overflow': 'hidden',
- 'white-space': 'nowrap',
- },
- editConfig: {
- maxLength: 20, // easier to allow more than less in the future..
- enforceMaxLength: true,
- },
- vtype: 'ConfigId',
- allowBlank: false,
- editable: me.isCreate,
- },
nodesel,
storagesel,
{
@@ -263,6 +245,10 @@ Ext.define('PVE.dc.BackupEdit', {
delete values.node;
}
+ if (!values.id && me.isCreate) {
+ values.id = 'backup-' + Ext.data.identifier.Uuid.Global.generate().slice(0, 13);
+ }
+
let selMode = values.selMode;
delete values.selMode;
--
2.30.2
next prev parent reply other threads:[~2021-11-11 11:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 11:07 [pve-devel] [PATCH docs/manager] add pvescheduler docs, improve vzdump job gui Dominik Csapak
2021-11-11 11:07 ` [pve-devel] [PATCH docs 1/3] refactor calendar events into appendix Dominik Csapak
2021-11-11 17:03 ` [pve-devel] applied-series: " Thomas Lamprecht
2021-11-11 11:07 ` [pve-devel] [PATCH docs 2/3] vzdump: change vzdump.cron to pvescheduler Dominik Csapak
2021-11-11 11:07 ` [pve-devel] [PATCH docs 3/3] add pvescheduler docs and manpage Dominik Csapak
2021-11-11 11:07 ` Dominik Csapak [this message]
2021-11-11 11:07 ` [pve-devel] [PATCH manager 2/5] ui: dc/Backup: fix comment sort Dominik Csapak
2021-11-11 11:07 ` [pve-devel] [PATCH manager 3/5] api: cluster: add jobs/schedule-analyze api call Dominik Csapak
2021-11-11 11:07 ` [pve-devel] [PATCH manager 4/5] ui: dc/Backup: add schedule simulator button Dominik Csapak
2021-11-11 11:07 ` [pve-devel] [PATCH manager 5/5] remove pvescheduler manpage generation Dominik Csapak
2021-11-11 20:04 ` [pve-devel] applied-series: [PATCH docs/manager] add pvescheduler docs, improve vzdump job gui Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211111110709.633855-5-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal