all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v3 proxmox-backup 4/5] api2: make maintenance_type updatable
Date: Mon,  8 Nov 2021 17:46:54 +0100	[thread overview]
Message-ID: <20211108164655.25913-5-h.laimer@proxmox.com> (raw)
In-Reply-To: <20211108164655.25913-1-h.laimer@proxmox.com>

And check if conflicting operations are currently active on the
datastore.
---
 src/api2/config/datastore.rs | 42 +++++++++++++++++++++++++++++++++++-
 1 file changed, 41 insertions(+), 1 deletion(-)

diff --git a/src/api2/config/datastore.rs b/src/api2/config/datastore.rs
index b9367469..cf16ce02 100644
--- a/src/api2/config/datastore.rs
+++ b/src/api2/config/datastore.rs
@@ -1,3 +1,5 @@
+use std::fs::File;
+use std::io::Read;
 use std::path::PathBuf;
 
 use anyhow::{bail, Error};
@@ -11,7 +13,7 @@ use proxmox_section_config::SectionConfigData;
 use pbs_datastore::chunk_store::ChunkStore;
 use pbs_config::BackupLockGuard;
 use pbs_api_types::{
-    Authid, DatastoreNotify,
+    Authid, MaintenanceType, DatastoreNotify,
     DATASTORE_SCHEMA, PROXMOX_CONFIG_DIGEST_SCHEMA,
     PRIV_DATASTORE_ALLOCATE, PRIV_DATASTORE_AUDIT, PRIV_DATASTORE_MODIFY,
     DataStoreConfig, DataStoreConfigUpdater,
@@ -183,6 +185,8 @@ pub enum DeletableProperty {
     notify_user,
     /// Delete the notify property
     notify,
+    /// Delete the maintenance-type property
+    maintenance_type,
 }
 
 #[api(
@@ -249,6 +253,7 @@ pub fn update_datastore(
                 DeletableProperty::verify_new => { data.verify_new = None; },
                 DeletableProperty::notify => { data.notify = None; },
                 DeletableProperty::notify_user => { data.notify_user = None; },
+                DeletableProperty::maintenance_type => { data.maintenance_type = None; },
             }
         }
     }
@@ -294,6 +299,41 @@ pub fn update_datastore(
 
     if update.notify_user.is_some() { data.notify_user = update.notify_user; }
 
+    if let Some(maintenance_type) = update.maintenance_type {
+        let (reading, writing) = {
+            let mut path = PathBuf::from(pbs_datastore::ACTIVE_OPERATIONS_DIR);
+            path.push(&name);
+            if let Ok(mut file) = File::open(path) {
+                let timeout = std::time::Duration::new(10, 0);
+                proxmox::tools::fs::lock_file(&mut file, false, Some(timeout))?;
+
+                let mut data = String::new();
+                file.read_to_string(&mut data)?;
+                if data.is_empty() {
+                    (0, 0)
+                } else {
+                    let tmp = data.split(" ").collect::<Vec<&str>>();
+                    (
+                        tmp[0].parse::<i64>().unwrap_or(0),
+                        tmp[1].parse::<i64>().unwrap_or(0),
+                    )
+                }
+            } else {
+                (0, 0)
+            }
+        };
+
+        match maintenance_type {
+            MaintenanceType::ReadOnly(_) if writing > 0 => {
+                bail!("Can't enable maintenance mode because {} conflicting operations are still active.", writing);
+            }
+            MaintenanceType::Offline(_) if writing + reading > 0 => {
+                bail!("Can't enable maintenance mode because {} conflicting operations are still active.", (writing+reading));
+            }
+            _ => data.maintenance_type = Some(maintenance_type),
+        }
+    }
+
     config.set_data(&name, "datastore", &data)?;
 
     pbs_config::datastore::save_config(&config)?;
-- 
2.30.2





  parent reply	other threads:[~2021-11-08 16:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 16:46 [pbs-devel] [PATCH v3 proxmox-backup 0/5] closes #3071: maintenance mode for datastore Hannes Laimer
2021-11-08 16:46 ` [pbs-devel] [PATCH v3 proxmox-backup 1/5] pbs-api-types: add maintenance type Hannes Laimer
2021-11-08 16:46 ` [pbs-devel] [PATCH v3 proxmox-backup 2/5] pbs-datastore: add check for maintenance in lookup Hannes Laimer
2021-11-08 16:46 ` [pbs-devel] [PATCH v3 proxmox-backup 3/5] pbs-datastore: add active operations tracking Hannes Laimer
2021-11-08 16:46 ` Hannes Laimer [this message]
2021-11-09  8:05   ` [pbs-devel] [PATCH v3 proxmox-backup 4/5] api2: make maintenance_type updatable Thomas Lamprecht
2021-11-08 16:46 ` [pbs-devel] [PATCH v3 proxmox-backup 5/5] ui: add option to change the maintenance type Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211108164655.25913-5-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal