From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2] api: zfs: create zpool with relatime=on
Date: Wed, 3 Nov 2021 08:36:51 +0100 [thread overview]
Message-ID: <20211103073651.170428-1-d.csapak@proxmox.com> (raw)
some operations (e.g. garbage collection/restore/etc.) are very read
intensive on the chunks, and having atime=on and relatime=off (zfs default)
makes those write intensive operations too. Additionally, 'ext4' defaults to
relatime, so also change the default for api-created zpools.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* do not disable atime, it must be on for relatime to work, quote
from 'man zfsprops' for 'relatime':
Controls the manner in which the access time is updated when atime=on is set.
src/api2/node/disks/zfs.rs | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/api2/node/disks/zfs.rs b/src/api2/node/disks/zfs.rs
index 9c3a0958..56dedab5 100644
--- a/src/api2/node/disks/zfs.rs
+++ b/src/api2/node/disks/zfs.rs
@@ -273,13 +273,15 @@ pub fn create_zpool(
proxmox_systemd::enable_unit(&import_unit)?;
}
+ let mut command = std::process::Command::new("zfs");
+ command.arg("set");
if let Some(compression) = compression {
- let mut command = std::process::Command::new("zfs");
- command.args(&["set", &format!("compression={}", compression), &name]);
- task_log!(worker, "# {:?}", command);
- let output = pbs_tools::run_command(command, None)?;
- task_log!(worker, "{}", output);
+ command.arg(&format!("compression={}", compression));
}
+ command.args(&["relatime=on", &name]);
+ task_log!(worker, "# {:?}", command);
+ let output = pbs_tools::run_command(command, None)?;
+ task_log!(worker, "{}", output);
if add_datastore {
let lock = pbs_config::datastore::lock_config()?;
--
2.30.2
next reply other threads:[~2021-11-03 7:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 7:36 Dominik Csapak [this message]
2021-12-15 14:59 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103073651.170428-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal