From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/4] PruneMark: use copied values instead of references
Date: Thu, 28 Oct 2021 11:47:52 +0200 [thread overview]
Message-ID: <20211028094755.3003184-1-d.csapak@proxmox.com> (raw)
the type is small enough
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
pbs-datastore/src/prune.rs | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/pbs-datastore/src/prune.rs b/pbs-datastore/src/prune.rs
index e66ed408..c144b3db 100644
--- a/pbs-datastore/src/prune.rs
+++ b/pbs-datastore/src/prune.rs
@@ -11,12 +11,12 @@ use super::BackupInfo;
pub enum PruneMark { Protected, Keep, KeepPartial, Remove }
impl PruneMark {
- pub fn keep(&self) -> bool {
- *self != PruneMark::Remove
+ pub fn keep(self) -> bool {
+ self != PruneMark::Remove
}
- pub fn protected(&self) -> bool {
- *self == PruneMark::Protected
+ pub fn protected(self) -> bool {
+ self == PruneMark::Protected
}
}
@@ -202,7 +202,7 @@ pub fn compute_prune_info(
let mark = if info.protected {
PruneMark::Protected
} else {
- *mark.get(&backup_id).unwrap_or(&PruneMark::Remove)
+ mark.get(&backup_id).copied().unwrap_or(PruneMark::Remove)
};
(info, mark)
--
2.30.2
next reply other threads:[~2021-10-28 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 9:47 Dominik Csapak [this message]
2021-10-28 9:47 ` [pbs-devel] [PATCH proxmox-backup 2/4] PruneMark: implement display without the write! macro Dominik Csapak
2021-10-28 9:47 ` [pbs-devel] [PATCH proxmox-backup 3/4] backup-client: use () instead of Value as return type Dominik Csapak
2021-10-28 9:47 ` [pbs-devel] [PATCH proxmox-backup 4/4] api: admin/datastore: reuse 'is_protected' implementation Dominik Csapak
2021-10-28 10:57 ` [pbs-devel] applied-series: [PATCH proxmox-backup 1/4] PruneMark: use copied values instead of references Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028094755.3003184-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal