From: "Phillipp Röll" <pr@lima-city.de>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH] Check only first part of script parameter for executability
Date: Thu, 21 Oct 2021 10:46:50 +0200 [thread overview]
Message-ID: <20211021084650.26753-1-pr@lima-city.de> (raw)
When giving a script parameter including arguments to the dump process,
the full script parameter including the arguments is checked for
executablility. The following will always abort with a "not executable"
error:
vzdump 100 --script "/usr/local/bin/myscript.pl myarg"
If we split the script argument and check only the first part, the
check works as expected.
---
PVE/VZDump.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 88ac11b3..fe1a7f23 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -630,7 +630,9 @@ sub run_hook_script {
my $script = $opts->{script};
return if !$script;
- if (!-x $script) {
+ my @script_args = split /\s+/, $script;
+
+ if (!-x $script_args[0]) {
die "The hook script '$script' is not executable.\n";
}
--
2.33.0
next reply other threads:[~2021-10-21 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 8:46 Phillipp Röll [this message]
2021-10-21 9:05 ` Thomas Lamprecht
2021-10-21 18:15 ` Phillipp Röll
2021-10-22 7:36 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021084650.26753-1-pr@lima-city.de \
--to=pr@lima-city.de \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.