all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH widget-toolkit] fix #3589: show device name in title for SMART values window
@ 2021-10-15 11:33 Dominik Csapak
  2021-10-18  7:23 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-10-15 11:33 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/window/DiskSmart.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js
index 6d35ea1..f11209e 100644
--- a/src/window/DiskSmart.js
+++ b/src/window/DiskSmart.js
@@ -12,7 +12,6 @@ Ext.define('Proxmox.window.DiskSmart', {
     minWidth: 400,
     minHeight: 300,
     bodyPadding: 5,
-    title: gettext('S.M.A.R.T. Values'),
 
     items: [
 	{
@@ -113,6 +112,8 @@ Ext.define('Proxmox.window.DiskSmart', {
 	    throw "no device specified";
 	}
 
+	me.title = gettext('S.M.A.R.T. Values') + ` (${dev})`;
+
 	me.store = Ext.create('Ext.data.Store', {
 	    model: 'pmx-disk-smart',
 	    proxy: {
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH widget-toolkit] fix #3589: show device name in title for SMART values window
  2021-10-15 11:33 [pve-devel] [PATCH widget-toolkit] fix #3589: show device name in title for SMART values window Dominik Csapak
@ 2021-10-18  7:23 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-10-18  7:23 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 15.10.21 13:33, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/window/DiskSmart.js | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied, thanks! Adapted it to only use a template in a follow up.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-18  7:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 11:33 [pve-devel] [PATCH widget-toolkit] fix #3589: show device name in title for SMART values window Dominik Csapak
2021-10-18  7:23 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal