all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server] fix removing cpulimit on running vm
Date: Tue, 12 Oct 2021 13:20:52 +0200	[thread overview]
Message-ID: <20211012112052.437232-1-d.csapak@proxmox.com> (raw)

like in pve-container:
04a62bd ("fix #3506: config: fix removing the cpulimit of a running CT")

reported in the forums (no bug# yet):
https://forum.proxmox.com/threads/issue-with-removing-cpu-limit-from-running-vm.97799/

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index eb29fc2..1d31d02 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4754,7 +4754,7 @@ sub vmconfig_hotplug_pending {
 	    } elsif ($opt eq 'cpuunits') {
 		$cgroup->change_cpu_shares(undef, 1024);
 	    } elsif ($opt eq 'cpulimit') {
-		$cgroup->change_cpu_quota(-1, 100000);
+		$cgroup->change_cpu_quota(undef, undef); # reset, cgroup module can better decide values
 	    } else {
 		die "skip\n";
 	    }
-- 
2.30.2





             reply	other threads:[~2021-10-12 11:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 11:20 Dominik Csapak [this message]
2021-10-21  9:53 ` Oguz Bektas
2021-10-21 10:51   ` Dominik Csapak
2021-10-21 11:43     ` Oguz Bektas
2021-10-21 14:21       ` Dominik Csapak
2021-10-21 14:51         ` Oguz Bektas
2021-10-22 10:04 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211012112052.437232-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal