From: Oguz Bektas <o.bektas@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 container 1/2] setup: fix creating unmanaged containers
Date: Tue, 5 Oct 2021 10:09:51 +0200 [thread overview]
Message-ID: <20211005080952.369898-2-o.bektas@proxmox.com> (raw)
In-Reply-To: <20211005080952.369898-1-o.bektas@proxmox.com>
ssh_host_key_generate did not explicitly return in unmanaged plugin,
causing the post_create_hook to fail because of an invalid hash
reference (cannot use "1" as a HASH ref, "1" was likely being returned
implicitly as the scalar value of 'my ($self) = @_;')
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
src/PVE/LXC/Setup/Unmanaged.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/LXC/Setup/Unmanaged.pm b/src/PVE/LXC/Setup/Unmanaged.pm
index 38e245f..3b9febf 100644
--- a/src/PVE/LXC/Setup/Unmanaged.pm
+++ b/src/PVE/LXC/Setup/Unmanaged.pm
@@ -51,6 +51,7 @@ sub unified_cgroupv2_support {
sub ssh_host_key_types_to_generate {
my ($self) = @_;
+ return;
}
# hooks
--
2.30.2
next prev parent reply other threads:[~2021-10-05 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 8:09 [pve-devel] [PATCH v2 container 0/2] " Oguz Bektas
2021-10-05 8:09 ` Oguz Bektas [this message]
2021-10-05 8:09 ` [pve-devel] [PATCH v2 container 2/2] setup: drop remaining unmanaged return Oguz Bektas
2021-10-05 8:54 ` [pve-devel] applied-series: [PATCH v2 container 0/2] unmanaged containers Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005080952.369898-2-o.bektas@proxmox.com \
--to=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.