all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] influxdb: do not test the connection when entry is disabled
@ 2021-09-30 11:38 Dominik Csapak
  2021-09-30 15:28 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-09-30 11:38 UTC (permalink / raw)
  To: pve-devel

else we cannot disable entries where influxdb is not reachable

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 PVE/Status/InfluxDB.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/PVE/Status/InfluxDB.pm b/PVE/Status/InfluxDB.pm
index ba434569..cb788c4e 100644
--- a/PVE/Status/InfluxDB.pm
+++ b/PVE/Status/InfluxDB.pm
@@ -244,6 +244,9 @@ sub _connect {
 sub test_connection {
     my ($class, $cfg, $id) = @_;
 
+    # do not check connection for disabled plugins
+    return if $cfg->{disable};
+
     my $proto = $cfg->{influxdbproto} // 'udp';
     if ($proto eq 'udp') {
 	return $class->SUPER::test_connection($cfg, $id);
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] influxdb: do not test the connection when entry is disabled
  2021-09-30 11:38 [pve-devel] [PATCH manager] influxdb: do not test the connection when entry is disabled Dominik Csapak
@ 2021-09-30 15:28 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-09-30 15:28 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 30.09.21 13:38, Dominik Csapak wrote:
> else we cannot disable entries where influxdb is not reachable
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  PVE/Status/InfluxDB.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-30 15:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 11:38 [pve-devel] [PATCH manager] influxdb: do not test the connection when entry is disabled Dominik Csapak
2021-09-30 15:28 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal