From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES storage/widget-toolkit/manager] disk creation and wiping improvements
Date: Tue, 28 Sep 2021 13:39:40 +0200 [thread overview]
Message-ID: <20210928114001.164081-1-f.ebner@proxmox.com> (raw)
which also fixes the remaining parts of #2285, i.e. extending
the diskmanage module and creation to support partitions.
The series consists of:
Tighten the checks in the disk creation paths by re-doing them after
forking/locking.
Work around a udev bug[0] leading to outdated device info from lsblk,
by explicitly calling udevadm trigger in the appropriate places.
Add support for partitions for the disk creation paths (both back-end
and UI).
Also change the partition type in the appropriate places as that
information is used when querying disk info.
[0]: https://github.com/systemd/systemd/issues/18525
Ultimately, pve-manager depends on both pve-storage and
proxmox-widget-toolkit, but many things can be applied independently.
pve-storage:
Fabian Ebner (10):
api: disks: create: re-check disk after fork/lock
api: disk: work around udev bug to ensure its database is updated
diskmanage: add change_parttype helper
diskmanage: wipe blockdev: also change partition type
diskmanage: don't set usage for unused partitions
api: disks: initgpt: explicitly abort for partitions
diskmanage: allow partitions for get_udev_info
diskmanage: allow passing partitions to get_disks
partially fix #2285: api: disks: allow partitions for creation paths
api: disks: create: set correct partition type
PVE/API2/Disks.pm | 12 +++++++-
PVE/API2/Disks/Directory.pm | 37 ++++++++++++++++-------
PVE/API2/Disks/LVM.pm | 15 +++++++++-
PVE/API2/Disks/LVMThin.pm | 13 ++++++++
PVE/API2/Disks/ZFS.pm | 36 ++++++++++++++++++++--
PVE/Diskmanage.pm | 60 +++++++++++++++++++++++++++++--------
6 files changed, 145 insertions(+), 28 deletions(-)
proxmox-widget-toolkit:
Fabian Ebner (2):
(multi) disk selector: allow requesting partitions too
disk list: allow wiping individual partitions
src/form/DiskSelector.js | 7 +++++++
src/form/MultiDiskSelector.js | 22 +++++++++++++++++-----
src/panel/DiskList.js | 8 --------
3 files changed, 24 insertions(+), 13 deletions(-)
pve-manager:
Fabian Ebner (9):
api: ceph: create osd: re-check disk requirements after fork/lock
api: check: create osd: use wipe_blockdev from the Diskmanage package
api: ceph: create osd: work around udev bug
api: ceph: create osd: set correct parttype for DB/WAL
partially fix #2285: api: ceph: create osd: allow using partitions
api: ceph: create osd: set correct partition type
partially fix #2285: ui: ceph: allow selecting partitions
ui: zfs create: switch to using widget-toolkit's multiDiskSelector
partially fix #2285: ui: disk create: allow selecting partitions
PVE/API2/Ceph/OSD.pm | 112 +++++++++++++++++++++++++--------
PVE/Ceph/Tools.pm | 23 -------
www/manager6/ceph/OSD.js | 3 +
www/manager6/node/Directory.js | 1 +
www/manager6/node/LVM.js | 1 +
www/manager6/node/LVMThin.js | 1 +
www/manager6/node/ZFS.js | 81 ++----------------------
7 files changed, 96 insertions(+), 126 deletions(-)
--
2.30.2
next reply other threads:[~2021-09-28 11:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 11:39 Fabian Ebner [this message]
2021-09-28 11:39 ` [pve-devel] [PATCH storage 01/10] api: disks: create: re-check disk after fork/lock Fabian Ebner
2021-09-30 16:06 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-28 11:39 ` [pve-devel] [PATCH storage 02/10] api: disk: work around udev bug to ensure its database is updated Fabian Ebner
2021-09-30 16:08 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-28 11:39 ` [pve-devel] [PATCH storage 03/10] diskmanage: add change_parttype helper Fabian Ebner
2021-09-28 11:39 ` [pve-devel] [PATCH storage 04/10] diskmanage: wipe blockdev: also change partition type Fabian Ebner
2021-09-28 11:39 ` [pve-devel] [PATCH storage 05/10] diskmanage: don't set usage for unused partitions Fabian Ebner
2021-09-28 11:39 ` [pve-devel] [PATCH storage 06/10] api: disks: initgpt: explicitly abort for partitions Fabian Ebner
2021-09-30 16:02 ` Thomas Lamprecht
2021-10-06 7:11 ` Fabian Ebner
2021-09-28 11:39 ` [pve-devel] [PATCH storage 07/10] diskmanage: allow partitions for get_udev_info Fabian Ebner
2021-09-30 16:10 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-28 11:39 ` [pve-devel] [PATCH storage 08/10] diskmanage: allow passing partitions to get_disks Fabian Ebner
2021-09-30 16:10 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-28 11:39 ` [pve-devel] [PATCH storage 09/10] partially fix #2285: api: disks: allow partitions for creation paths Fabian Ebner
2021-09-28 11:39 ` [pve-devel] [PATCH storage 10/10] api: disks: create: set correct partition type Fabian Ebner
2021-09-28 11:39 ` [pve-devel] [PATCH widget-toolkit 1/2] (multi) disk selector: allow requesting partitions too Fabian Ebner
2021-09-30 16:13 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-28 11:39 ` [pve-devel] [PATCH widget-toolkit 2/2] disk list: allow wiping individual partitions Fabian Ebner
2021-09-28 11:39 ` [pve-devel] [PATCH manager 1/9] api: ceph: create osd: re-check disk requirements after fork/lock Fabian Ebner
2021-09-30 16:12 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-28 11:39 ` [pve-devel] [PATCH manager 2/9] api: check: create osd: use wipe_blockdev from the Diskmanage package Fabian Ebner
2021-09-30 16:12 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-28 11:39 ` [pve-devel] [PATCH manager 3/9] api: ceph: create osd: work around udev bug Fabian Ebner
2021-09-30 16:12 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-28 11:39 ` [pve-devel] [PATCH manager 4/9] api: ceph: create osd: set correct parttype for DB/WAL Fabian Ebner
2021-09-28 11:39 ` [pve-devel] [RFC manager 5/9] partially fix #2285: api: ceph: create osd: allow using partitions Fabian Ebner
2021-09-28 11:39 ` [pve-devel] [RFC manager 6/9] api: ceph: create osd: set correct partition type Fabian Ebner
2021-09-28 11:39 ` [pve-devel] [RFC manager 7/9] partially fix #2285: ui: ceph: allow selecting partitions Fabian Ebner
2021-09-28 11:40 ` [pve-devel] [PATCH manager 8/9] ui: zfs create: switch to using widget-toolkit's multiDiskSelector Fabian Ebner
2021-09-28 11:40 ` [pve-devel] [PATCH manager 9/9] partially fix #2285: ui: disk create: allow selecting partitions Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928114001.164081-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal