all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC storage/manager] fix #3307: allow backups to be marked as protected
Date: Fri, 17 Sep 2021 15:02:20 +0200	[thread overview]
Message-ID: <20210917130227.248852-1-f.ebner@proxmox.com> (raw)

Protected bacukps cannot be removed accidentally and will be ignored
for pruning. A <backup>.protected file serves as a protection marker
for file-based storages.


Still missing: GUI integration


The pve-manager patch depends on the pve-storage patches.

To work, the PBS integration needs Dominik's patches for PBS:
https://lists.proxmox.com/pipermail/pbs-devel/2021-September/003926.html


pve-storage:

Fabian Ebner (6):
  dir plugin: update notes: don't attempt to remove non-existent notes
  add generalized functions to manage volume attributes
  prune mark: preserve additional information for the keep-all case
  fix #3307: make it possible to set protection for backups
  prune: mark renamed and protected backups differently
  pbs: integrate support for protected

 PVE/API2/Storage/Content.pm      | 36 ++++++++++++----
 PVE/API2/Storage/PruneBackups.pm |  5 ++-
 PVE/Storage.pm                   | 23 +++++++---
 PVE/Storage/BTRFSPlugin.pm       |  4 +-
 PVE/Storage/CIFSPlugin.pm        | 10 +++--
 PVE/Storage/CephFSPlugin.pm      | 10 +++--
 PVE/Storage/DirPlugin.pm         | 61 ++++++++++++++++++++------
 PVE/Storage/NFSPlugin.pm         | 10 +++--
 PVE/Storage/PBSPlugin.pm         | 73 +++++++++++++++++++++++++++-----
 PVE/Storage/Plugin.pm            | 45 +++++++++++++++++++-
 test/prune_backups_test.pm       | 17 +++++++-
 11 files changed, 236 insertions(+), 58 deletions(-)


pve-manager:

Fabian Ebner (1):
  vzdump: skip protected backups for dumpdir pruning

 PVE/VZDump.pm | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.30.2





             reply	other threads:[~2021-09-17 13:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 13:02 Fabian Ebner [this message]
2021-09-17 13:02 ` [pve-devel] [PATCH storage 1/6] dir plugin: update notes: don't attempt to remove non-existent notes Fabian Ebner
2021-09-24  8:54   ` Dominik Csapak
2021-09-24  9:03     ` Thomas Lamprecht
2021-09-24 10:40       ` Fabian Ebner
2021-09-17 13:02 ` [pve-devel] [RFC storage 2/6] add generalized functions to manage volume attributes Fabian Ebner
2021-09-24  8:54   ` Dominik Csapak
2021-09-24 11:05     ` Fabian Ebner
2021-09-24 11:16       ` Dominik Csapak
2021-09-24 11:31         ` Fabian Ebner
2021-09-17 13:02 ` [pve-devel] [PATCH storage 3/6] prune mark: preserve additional information for the keep-all case Fabian Ebner
2021-09-17 13:02 ` [pve-devel] [RFC storage 4/6] fix #3307: make it possible to set protection for backups Fabian Ebner
2021-09-24  8:54   ` Dominik Csapak
2021-09-24 11:17     ` Fabian Ebner
2021-09-17 13:02 ` [pve-devel] [RFC storage 5/6] prune: mark renamed and protected backups differently Fabian Ebner
2021-09-17 13:02 ` [pve-devel] [RFC storage 6/6] pbs: integrate support for protected Fabian Ebner
2021-09-24  8:55   ` Dominik Csapak
2021-09-24 11:32     ` Fabian Ebner
2021-09-24 11:48       ` Dominik Csapak
2021-09-17 13:02 ` [pve-devel] [RFC manager 1/1] vzdump: skip protected backups for dumpdir pruning Fabian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210917130227.248852-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal