From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/2] ui: form/ControllerSelector: set correct max value for the device-id
Date: Thu, 16 Sep 2021 08:54:50 +0200 [thread overview]
Message-ID: <20210916065450.87803-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210916065450.87803-1-d.csapak@proxmox.com>
the 'diskControllerMaxIDs' object in Utils does not describe the
'maximum ids', but the maximum *number* of ids, so the max is one less
correctly set that instead
the api rejected those values (e.g. ide4) already, so its only a ui change
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
noticed while working on the multi disk wizard panel
www/manager6/form/ControllerSelector.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js
index daca2432..27c06169 100644
--- a/www/manager6/form/ControllerSelector.js
+++ b/www/manager6/form/ControllerSelector.js
@@ -95,7 +95,7 @@ Ext.define('PVE.form.ControllerSelector', {
return;
}
let field = me.down('field[name=deviceid]');
- field.setMaxValue(PVE.Utils.diskControllerMaxIDs[value]);
+ field.setMaxValue(PVE.Utils.diskControllerMaxIDs[value] - 1);
field.validate();
},
},
@@ -104,7 +104,7 @@ Ext.define('PVE.form.ControllerSelector', {
xtype: 'proxmoxintegerfield',
name: 'deviceid',
minValue: 0,
- maxValue: PVE.Utils.diskControllerMaxIDs.ide,
+ maxValue: PVE.Utils.diskControllerMaxIDs.ide - 1,
value: '0',
flex: 1,
allowBlank: false,
--
2.30.2
prev parent reply other threads:[~2021-09-16 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 6:54 [pve-devel] [PATCH manager 1/2] ui: qemu/HDEdit: move Bandwidth options to a different tab Dominik Csapak
2021-09-16 6:54 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210916065450.87803-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal