all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: prune: fix order of keep reasons
@ 2021-09-07 10:08 Fabian Ebner
  2021-09-08 10:58 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Ebner @ 2021-09-07 10:08 UTC (permalink / raw)
  To: pve-devel

This is the same as fix 40ff84b138bb7127ecc05a2f587cca4e7a917810 in
proxmox-backup. When returning a boolean instead of the expected
{negative, 0, positive}, the behavior is browser-dependent.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 www/manager6/window/Prune.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/www/manager6/window/Prune.js b/www/manager6/window/Prune.js
index f503773d..3056ab20 100644
--- a/www/manager6/window/Prune.js
+++ b/www/manager6/window/Prune.js
@@ -63,9 +63,7 @@ Ext.define('PVE.PruneInputPanel', {
 		];
 		let counter = {};
 
-		backups.sort(function(a, b) {
-		    return a.ctime < b.ctime;
-		});
+		backups.sort((a, b) => b.ctime - a.ctime);
 
 		let ruleIndex = -1;
 		let nextRule = function() {
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] ui: prune: fix order of keep reasons
  2021-09-07 10:08 [pve-devel] [PATCH manager] ui: prune: fix order of keep reasons Fabian Ebner
@ 2021-09-08 10:58 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-09-08 10:58 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fabian Ebner

On 07.09.21 12:08, Fabian Ebner wrote:
> This is the same as fix 40ff84b138bb7127ecc05a2f587cca4e7a917810 in
> proxmox-backup. When returning a boolean instead of the expected
> {negative, 0, positive}, the behavior is browser-dependent.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  www/manager6/window/Prune.js | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-08 10:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 10:08 [pve-devel] [PATCH manager] ui: prune: fix order of keep reasons Fabian Ebner
2021-09-08 10:58 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal