From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 5/6] ui: backup job detail: also show retention settings
Date: Mon, 6 Sep 2021 13:32:30 +0200 [thread overview]
Message-ID: <20210906113231.61790-6-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210906113231.61790-1-f.ebner@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
www/manager6/dc/Backup.js | 115 ++++++++++++++++++++++++++++++++++++++
1 file changed, 115 insertions(+)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index ff52e382..68f67811 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -589,6 +589,16 @@ Ext.define('PVE.dc.BackupInfo', {
extend: 'Proxmox.panel.InputPanel',
alias: 'widget.pveBackupInfo',
+ viewModel: {
+ data: {
+ retentionType: 'none',
+ },
+ formulas: {
+ hasRetention: (get) => get('retentionType') !== 'none',
+ retentionKeepAll: (get) => get('retentionType') === 'all',
+ },
+ },
+
padding: '5 0 5 10',
column1: [
@@ -693,8 +703,81 @@ Ext.define('PVE.dc.BackupInfo', {
},
],
+ columnB: [
+ {
+ xtype: 'label',
+ name: 'pruneLabel',
+ text: gettext('Retention Configuration') + ':',
+ bind: {
+ hidden: '{!hasRetention}',
+ },
+ },
+ {
+ layout: 'hbox',
+ border: false,
+ defaults: {
+ border: false,
+ layout: 'anchor',
+ flex: 1,
+ },
+ items: [
+ {
+ padding: '0 10 0 0',
+ defaults: {
+ labelWidth: 110,
+ },
+ items: [{
+ xtype: 'displayfield',
+ name: 'keep-all',
+ fieldLabel: gettext('Keep All'),
+ renderer: Proxmox.Utils.format_boolean,
+ bind: {
+ hidden: '{!retentionKeepAll}',
+ },
+ }].concat(
+ [
+ ['keep-last', gettext('Keep Last')],
+ ['keep-daily', gettext('Keep Daily')],
+ ['keep-monthly', gettext('Keep Monthly')],
+ ].map(
+ name => ({
+ xtype: 'displayfield',
+ name: name[0],
+ fieldLabel: name[1],
+ bind: {
+ hidden: '{!hasRetention || retentionKeepAll}',
+ },
+ }),
+ ),
+ ),
+ },
+ {
+ padding: '0 0 0 10',
+ defaults: {
+ labelWidth: 110,
+ },
+ items: [
+ ['keep-hourly', gettext('Keep Hourly')],
+ ['keep-weekly', gettext('Keep Weekly')],
+ ['keep-yearly', gettext('Keep Yearly')],
+ ].map(
+ name => ({
+ xtype: 'displayfield',
+ name: name[0],
+ fieldLabel: name[1],
+ bind: {
+ hidden: '{!hasRetention || retentionKeepAll}',
+ },
+ }),
+ ),
+ },
+ ],
+ },
+ ],
+
setValues: function(values) {
var me = this;
+ let vm = me.getViewModel();
Ext.iterate(values, function(fieldId, val) {
let field = me.query('[isFormField][name=' + fieldId + ']')[0];
@@ -703,6 +786,38 @@ Ext.define('PVE.dc.BackupInfo', {
}
});
+ if (values['prune-backups'] || values.maxfiles !== undefined) {
+ const keepNames = [
+ 'keep-all',
+ 'keep-last',
+ 'keep-hourly',
+ 'keep-daily',
+ 'keep-weekly',
+ 'keep-monthly',
+ 'keep-yearly',
+ ];
+
+ let keepValues;
+ if (values['prune-backups']) {
+ keepValues = values['prune-backups'];
+ } else if (values.maxfiles > 0) {
+ keepValues = { 'keep-last': values.maxfiles };
+ } else {
+ keepValues = { 'keep-all': 1 };
+ }
+
+ vm.set('retentionType', keepValues['keep-all'] ? 'all' : 'other');
+
+ keepNames.forEach(function(name) {
+ let field = me.query('[isFormField][name=' + name + ']')[0];
+ if (field) {
+ field.setValue(keepValues[name]);
+ }
+ });
+ } else {
+ vm.set('retentionType', 'none');
+ }
+
// selection Mode depends on the presence/absence of several keys
let selModeField = me.query('[isFormField][name=selMode]')[0];
let selMode = 'none';
--
2.30.2
next prev parent reply other threads:[~2021-09-06 11:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 11:32 [pve-devel] [PATCH-SERIES manager] ui: some backup job improvements Fabian Ebner
2021-09-06 11:32 ` [pve-devel] [PATCH manager 1/6] ui: cluster backup: fix running backup with prune settings Fabian Ebner
2021-09-08 10:59 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-06 11:32 ` [pve-devel] [PATCH manager 2/6] ui: factor out input panel for editing " Fabian Ebner
2021-09-08 11:01 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-06 11:32 ` [pve-devel] [PATCH manager 3/6] ui: prune edit: prepare for being re-used for backup jobs Fabian Ebner
2021-09-08 11:01 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-06 11:32 ` [pve-devel] [PATCH manager 4/6] fix #1803: ui: cluster backup: handle job-specific retention options Fabian Ebner
2021-09-08 11:01 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-06 11:32 ` Fabian Ebner [this message]
2021-09-08 11:04 ` [pve-devel] [PATCH manager 5/6] ui: backup job detail: also show retention settings Thomas Lamprecht
2021-09-08 14:15 ` [pve-devel] applied: " Thomas Lamprecht
2021-09-06 11:32 ` [pve-devel] [PATCH manager 6/6] ui: cluster backup: use cluster-wide storage selector Fabian Ebner
2021-09-08 11:06 ` Thomas Lamprecht
2021-09-09 6:56 ` Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210906113231.61790-6-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.