From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container 1/3] config: snapshot_delete_remove_drive: check for parsed value
Date: Thu, 5 Aug 2021 09:19:56 +0200 [thread overview]
Message-ID: <20210805071958.4402-5-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210805071958.4402-1-f.ebner@proxmox.com>
to avoid a potential warning. parse_volume is called with noerr=1, so this might
be undef instead of a hash.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
src/PVE/LXC/Config.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 8557e4c..f832f90 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -192,7 +192,7 @@ sub __snapshot_delete_remove_drive {
delete $snap->{$remove_drive};
$class->add_unused_volume($snap, $mountpoint->{volume})
- if ($mountpoint->{type} eq 'volume');
+ if $mountpoint && ($mountpoint->{type} eq 'volume');
}
}
--
2.30.2
next prev parent reply other threads:[~2021-08-05 7:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 7:19 [pve-devel] [PATCH-SERIES guest-common/qemu-server/container] activate storages for snapshot operations Fabian Ebner
2021-08-05 7:19 ` [pve-devel] [PATCH guest-common 1/2] config: remove unused variable Fabian Ebner
2021-08-05 7:19 ` [pve-devel] [PATCH guest-common 2/2] config: activate affected storages for snapshot operations Fabian Ebner
2021-08-05 7:19 ` [pve-devel] [PATCH qemu-server 1/1] snapshot: implement __snapshot_activate_storages Fabian Ebner
2021-08-05 7:19 ` Fabian Ebner [this message]
2021-08-05 7:19 ` [pve-devel] [PATCH container 2/3] config: parse_volume: don't die when noerr is set Fabian Ebner
2021-08-05 7:19 ` [pve-devel] [PATCH container 3/3] snapshot: implement __snapshot_activate_storages Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210805071958.4402-5-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.