From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 3/3] tape: changer: add tests for decode_element_status_page
Date: Wed, 28 Jul 2021 12:05:11 +0200 [thread overview]
Message-ID: <20210728100511.2862784-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210728100511.2862784-1-d.csapak@proxmox.com>
a test for a valid status_page, one with excess data
(in the descriptor as well in the page as a whole)
and a test with too little data
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/tape/changer/sg_pt_changer.rs | 138 ++++++++++++++++++++++++++++++
1 file changed, 138 insertions(+)
diff --git a/src/tape/changer/sg_pt_changer.rs b/src/tape/changer/sg_pt_changer.rs
index 7ff9bc9d..8451e8e8 100644
--- a/src/tape/changer/sg_pt_changer.rs
+++ b/src/tape/changer/sg_pt_changer.rs
@@ -818,3 +818,141 @@ pub fn open<P: AsRef<Path>>(path: P) -> Result<File, Error> {
Ok(file)
}
+
+#[cfg(test)]
+mod test {
+ use anyhow::Error;
+ use super::*;
+
+ struct StorageDesc {
+ address: u16,
+ pvoltag: Option<String>,
+ }
+
+ fn build_element_status_page(
+ descriptors: Vec<StorageDesc>,
+ trailing: &[u8],
+ element_type: u8,
+ ) -> Vec<u8> {
+ let descs: Vec<Vec<u8>> = descriptors.iter().map(|desc| {
+ build_storage_descriptor(&desc, trailing)
+ }).collect();
+
+ let (desc_len, address) = if let Some(el) = descs.get(0) {
+ (el.len() as u16, descriptors[0].address)
+ } else {
+ (0u16, 0u16)
+ };
+
+ let descriptor_byte_count = desc_len * descs.len() as u16;
+ let byte_count = 8 + descriptor_byte_count;
+
+ let mut res = Vec::new();
+
+ res.extend_from_slice(&address.to_be_bytes());
+ res.extend_from_slice(&(descs.len() as u16).to_be_bytes());
+ res.push(0);
+ let byte_count = byte_count as u32;
+ res.extend_from_slice(&byte_count.to_be_bytes()[1..]);
+
+ res.push(element_type);
+ res.push(0x80);
+ res.extend_from_slice(&desc_len.to_be_bytes());
+ res.push(0);
+ let descriptor_byte_count = descriptor_byte_count as u32;
+ res.extend_from_slice(&descriptor_byte_count.to_be_bytes()[1..]);
+
+ for desc in descs {
+ res.extend_from_slice(&desc);
+ }
+
+ res.extend_from_slice(trailing);
+
+ res
+ }
+
+ fn build_storage_descriptor(
+ desc: &StorageDesc,
+ trailing: &[u8],
+ ) -> Vec<u8> {
+ let mut res = Vec::new();
+ res.push(((desc.address >> 8) & 0xFF) as u8);
+ res.push((desc.address & 0xFF) as u8);
+ if desc.pvoltag.is_some() {
+ res.push(0x01); // full
+ } else {
+ res.push(0x00); // full
+ }
+
+ res.extend_from_slice(&[0,0,0,0,0,0,0x80]);
+ res.push(((desc.address >> 8) & 0xFF) as u8);
+ res.push((desc.address & 0xFF) as u8);
+
+ if let Some(voltag) = &desc.pvoltag {
+ res.extend_from_slice(voltag.as_bytes());
+ let rem = SCSI_VOLUME_TAG_LEN - voltag.as_bytes().len();
+ if rem > 0 {
+ res.resize(res.len() + rem, 0);
+ }
+ }
+
+ res.extend_from_slice(trailing);
+
+ res
+ }
+
+ #[test]
+ fn status_page_valid() -> Result<(), Error> {
+ let descs = vec![
+ StorageDesc {
+ address: 0,
+ pvoltag: Some("0123456789".to_string()),
+ },
+ StorageDesc {
+ address: 1,
+ pvoltag: Some("1234567890".to_string()),
+ },
+ ];
+ let test_data = build_element_status_page(descs, &[], 0x2);
+ let page = decode_element_status_page(&test_data, 0)?;
+ assert_eq!(page.storage_slots.len(), 2);
+ Ok(())
+ }
+
+ #[test]
+ fn status_page_too_short() -> Result<(), Error> {
+ let descs = vec![
+ StorageDesc {
+ address: 0,
+ pvoltag: Some("0123456789".to_string()),
+ },
+ StorageDesc {
+ address: 1,
+ pvoltag: Some("1234567890".to_string()),
+ },
+ ];
+ let test_data = build_element_status_page(descs, &[], 0x2);
+ let len = test_data.len();
+ let res = decode_element_status_page(&test_data[..(len - 10)], 0);
+ assert!(res.is_err());
+ Ok(())
+ }
+
+ #[test]
+ fn status_page_too_large() -> Result<(), Error> {
+ let descs = vec![
+ StorageDesc {
+ address: 0,
+ pvoltag: Some("0123456789".to_string()),
+ },
+ StorageDesc {
+ address: 1,
+ pvoltag: Some("1234567890".to_string()),
+ },
+ ];
+ let test_data = build_element_status_page(descs, &[0,0,0,0,0], 0x2);
+ let page = decode_element_status_page(&test_data, 0)?;
+ assert_eq!(page.storage_slots.len(), 2);
+ Ok(())
+ }
+}
--
2.30.2
next prev parent reply other threads:[~2021-07-28 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 10:05 [pbs-devel] [PATCH proxmox-backup 0/3] improve status page decoding Dominik Csapak
2021-07-28 10:05 ` [pbs-devel] [PATCH proxmox-backup 1/3] tape: changer: remove unnecesary inquiry parameter Dominik Csapak
2021-07-28 10:20 ` [pbs-devel] applied: " Dietmar Maurer
2021-07-28 10:05 ` [pbs-devel] [PATCH proxmox-backup 2/3] tape: changer: handle libraries that sends wrong amount of data Dominik Csapak
2021-07-28 10:35 ` [pbs-devel] applied: " Dietmar Maurer
2021-07-28 10:05 ` Dominik Csapak [this message]
2021-07-28 10:35 ` [pbs-devel] applied: [PATCH proxmox-backup 3/3] tape: changer: add tests for decode_element_status_page Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728100511.2862784-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal