all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Mira Limbeck <m.limbeck@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: remove local cloud-init live migration limitation
Date: Tue, 27 Jul 2021 18:42:01 +0200	[thread overview]
Message-ID: <20210727164201.1877008-1-m.limbeck@proxmox.com> (raw)

With live migration with local cloud-init disk now possible via the CLI
also remove the limitation in the GUI.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
---
 www/manager6/window/Migrate.js | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index 5122e25f..1c23abb3 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/window/Migrate.js
@@ -252,15 +252,7 @@ Ext.define('PVE.window.Migrate', {
 	    if (migrateStats.local_disks.length) {
 		migrateStats.local_disks.forEach(function(disk) {
 		    if (disk.cdrom && disk.cdrom === 1) {
-			if (disk.volid.includes('vm-' + vm.get('vmid') + '-cloudinit')) {
-			    if (migrateStats.running) {
-				migration.possible = false;
-				migration.preconditions.push({
-				     text: "Can't live migrate VM with local cloudinit disk, use shared storage instead",
-				     severity: 'error',
-				});
-			    }
-			} else {
+			if (!disk.volid.includes('vm-' + vm.get('vmid') + '-cloudinit')) {
 			    migration.possible = false;
 			    migration.preconditions.push({
 				text: "Can't migrate VM with local CD/DVD",
-- 
2.30.2





             reply	other threads:[~2021-07-27 16:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 16:42 Mira Limbeck [this message]
2021-07-29  8:43 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210727164201.1877008-1-m.limbeck@proxmox.com \
    --to=m.limbeck@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal