From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH common 2/2] interfaces: improve bridge_fd handling
Date: Fri, 16 Jul 2021 09:40:50 +0200 [thread overview]
Message-ID: <20210716074050.3981444-2-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20210716074050.3981444-1-f.gruenbichler@proxmox.com>
and ignore values with a warning that are outside of the kernels
expected range.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
src/PVE/INotify.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm
index 4f682be..ad45cd2 100644
--- a/src/PVE/INotify.pm
+++ b/src/PVE/INotify.pm
@@ -1265,8 +1265,10 @@ sub __interface_to_string {
$v = defined($d->{bridge_fd}) ? $d->{bridge_fd} : 0;
# 0 is only allowed when STP is disabled
- if ($v || $no_stp) {
+ if ($no_stp || ($v >= 2 && $v <= 30)) {
$raw .= "\tbridge-fd $v\n";
+ } else {
+ warn "'$iface': not setting 'bridge_fd' to value '$v' outside of allowed range 2-30\n";
}
$done->{bridge_fd} = 1;
--
2.30.2
next prev parent reply other threads:[~2021-07-16 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 7:40 [pve-devel] [PATCH common 1/2] fix #2831: never set bridge_fd to 0 with STP on Fabian Grünbichler
2021-07-16 7:40 ` Fabian Grünbichler [this message]
2021-07-16 10:56 ` [pve-devel] [PATCH common 2/2] interfaces: improve bridge_fd handling Thomas Lamprecht
2021-07-16 10:54 ` [pve-devel] applied: [PATCH common 1/2] fix #2831: never set bridge_fd to 0 with STP on Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716074050.3981444-2-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.