all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 4/5 v2] dc options: Add apt notifications GUI checkbox
Date: Wed, 14 Jul 2021 12:09:32 +0200	[thread overview]
Message-ID: <20210714100933.54491-4-d.jaeger@proxmox.com> (raw)
In-Reply-To: <20210714100933.54491-1-d.jaeger@proxmox.com>

Default value like pveupdate: Assume users with subscriptions want
notifications

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
v2: default depends on subscription status

 www/manager6/dc/OptionView.js | 37 +++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index edae97ea..ec6ff1a3 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -90,6 +90,43 @@ Ext.define('PVE.dc.OptionView', {
 	    vtype: 'proxmoxMail',
 	    defaultValue: 'root@$hostname',
 	});
+	me.add_inputpanel_row('notify', gettext('Notification settings'), {
+	    renderer: PVE.Utils.render_dc_ha_opts,
+	    labelWidth: 120,
+	    url: "/api2/extjs/cluster/options",
+	    items: [
+		{
+		    xtype: 'checkbox',
+		    name: 'package_updates',
+		    fieldLabel: gettext('Package updates'),
+		    inputValue: 1,
+		    uncheckedValue: 0, // behavior for undefined is different
+		    listeners: {
+			added: function(checkbox) {
+			    Proxmox.Utils.API2Request({
+				url: '/nodes/localhost/subscription',
+				method: 'GET',
+				failure: function(response) {
+				    console.warn('Unable to load subscription status: '
+					+ response.htmlStatus);
+				},
+				success: function(response) {
+				    const data = response.result.data;
+				    // This happens after the row is clicked and the edit window
+				    // opens but before the setValue from add_inputpanel_row sets
+				    // the value that is (potentially) saved in datacenter.cfg. If
+				    // no value is in datacenter.cfg then the setValue from
+				    // add_inputpanel_row does nothing. Then this setValue uses the
+				    // subscription status as default like pveupdate.
+				    checkbox.setValue(data.status ==='Active');
+				},
+			    });
+			},
+		    },
+		},
+	    ],
+	});
+
 	me.add_text_row('mac_prefix', gettext('MAC address prefix'), {
 	    deleteEmpty: true,
 	    vtype: 'MacPrefix',
-- 
2.30.2





  parent reply	other threads:[~2021-07-14 10:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 10:09 [pve-devel] [PATCH cluster 1/5 v2] Close #1295: Add notifications to datacenter schema Dominic Jäger
2021-07-14 10:09 ` [pve-devel] [PATCH manager 2/5 v2] apt update: Inform users about missing subscriptions Dominic Jäger
2021-07-14 10:09 ` [pve-devel] [PATCH manager 3/5 v2] Close #1295: Make apt notifications configurable Dominic Jäger
2021-07-14 10:09 ` Dominic Jäger [this message]
2021-07-14 10:09 ` [pve-devel] [PATCH manager 5/5 v2] dc options: Allow both package_update options Dominic Jäger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210714100933.54491-4-d.jaeger@proxmox.com \
    --to=d.jaeger@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal