all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2] ui: NodeInfo: add link to repositories
Date: Tue, 13 Jul 2021 12:58:49 +0200	[thread overview]
Message-ID: <20210713105849.3374725-1-d.csapak@proxmox.com> (raw)

to guide the user to the repository panel from the dashboard

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* use different icon
* make sure the icon stays black
  (i did not see the purple link... should check my eyes^^)
* use better variable name
* use tooltip

regarding the use of a 'normal' link, there are two alternatives as i
see it, and both are not optimal:
* create an component inline (Ext.create) and add a handler, etc.
   i'd avoid that in a viewmodel formula (do not know the side effects
   of that)
* add a click handler/tooltip across the whole 'value' part of the panel
  idk if we want that, it would mean the tooltip/click handler is for
  the whole value part

if one of those solutions is preferred, please tell, i'll send a v3

 www/panel/NodeInfo.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/www/panel/NodeInfo.js b/www/panel/NodeInfo.js
index ff96e8fc..a8c450f6 100644
--- a/www/panel/NodeInfo.js
+++ b/www/panel/NodeInfo.js
@@ -46,7 +46,11 @@ Ext.define('PBS.NodeInfoPanel', {
 	    },
 	    repoStatusMessage: function(get) {
 		const status = get('repoStatus');
-		return Proxmox.Utils.formatNodeRepoStatus(status, 'Proxmox Backup Server');
+		let repoLink = ` <a data-qtip="${gettext("Open Repositories Panel")}"
+		    href="#pbsServerAdministration:aptrepositories">
+		    <i class="fa black fa-chevron-right"></i>
+		    </a>`;
+		return Proxmox.Utils.formatNodeRepoStatus(status, 'Proxmox Backup Server') + repoLink;
 	    },
 	},
     },
-- 
2.30.2





                 reply	other threads:[~2021-07-13 10:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210713105849.3374725-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal