all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Reiter <s.reiter@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/2] fix #3515: file-restore-daemon: allow LVs with dash in name
Date: Tue, 13 Jul 2021 11:19:26 +0200	[thread overview]
Message-ID: <20210713091926.587025-2-s.reiter@proxmox.com> (raw)
In-Reply-To: <20210713091926.587025-1-s.reiter@proxmox.com>

LVM replaces any dashes '-' in an LV name with two '--' for the created
device node in /dev/mapper/ to distinguish the seperating character
between the PV and LV name.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
 src/bin/proxmox_restore_daemon/disk.rs | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/bin/proxmox_restore_daemon/disk.rs b/src/bin/proxmox_restore_daemon/disk.rs
index 1bcfc798..1e6f9ed0 100644
--- a/src/bin/proxmox_restore_daemon/disk.rs
+++ b/src/bin/proxmox_restore_daemon/disk.rs
@@ -308,7 +308,11 @@ impl Filesystems {
                 let mntpath = format!("/mnt/lvm/{}/{}", &data.vg_name, &data.lv_name);
                 create_dir_all(&mntpath)?;
 
-                let mapper_path = format!("/dev/mapper/{}-{}", &data.vg_name, &data.lv_name);
+                let mapper_path = format!(
+                    "/dev/mapper/{}-{}",
+                    &data.vg_name,
+                    &data.lv_name.replace('-', "--")
+                );
                 self.try_mount(&mapper_path, &mntpath)?;
 
                 let mp = PathBuf::from(mntpath);
-- 
2.30.2





      reply	other threads:[~2021-07-13  9:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  9:19 [pbs-devel] [PATCH proxmox-backup 1/2] file-restore: increase lock timeout on QEMU map Stefan Reiter
2021-07-13  9:19 ` Stefan Reiter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210713091926.587025-2-s.reiter@proxmox.com \
    --to=s.reiter@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal