all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Rhonda D'Vine <rhonda@deb.at>
To: Fabian Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve-manager 1/1] Only check deb sources.list entries
Date: Fri, 9 Jul 2021 10:49:30 +0200	[thread overview]
Message-ID: <20210709084930.GA6337@mirage.deb.at> (raw)
In-Reply-To: <1f1bddca-81c3-816e-6b57-fd6d15bec6d8@proxmox.com>

   Hi,

* Fabian Ebner <f.ebner@proxmox.com> [2021-07-09 10:33:08 CEST]:
> Am 09.07.21 um 09:24 schrieb Rhonda D'Vine:
> > --- a/PVE/CLI/pve6to7.pm
> > +++ b/PVE/CLI/pve6to7.pm
> > @@ -1010,7 +1010,7 @@ sub check_security_repo {
> >   	    ($line) = split(/#/, $line);
> > -	    next if $line !~ m/^deb/; # is case sensitive
> > +	    next if $line !~ m/^deb[[:space:]]/; # is case sensitive
> >   	    my $suite;
> 
> Of course, thank you for the fix!
> 
> FWIW, Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
> 
> I also noticed that the check is not yet in the stable-6 branch.

 Right, I didn't check which branches this should be applied, but I
assume that the commit should apply without any troubles there too (and
obviously would make more sense in that branch).

 Cheers,
Rhonda
-- 
Fühlst du dich mutlos, fass endlich Mut, los      |
Fühlst du dich hilflos, geh raus und hilf, los    | Wir sind Helden
Fühlst du dich machtlos, geh raus und mach, los   | 23.55: Alles auf Anfang
Fühlst du dich haltlos, such Halt und lass los    |



  reply	other threads:[~2021-07-09  8:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09  7:24 [pve-devel] [PATCH pve-manager 0/1] " Rhonda D'Vine
2021-07-09  7:24 ` [pve-devel] [PATCH pve-manager 1/1] " Rhonda D'Vine
2021-07-09  8:33   ` Fabian Ebner
2021-07-09  8:49     ` Rhonda D'Vine [this message]
2021-07-13  4:53     ` Thomas Lamprecht
2021-07-13  4:34   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210709084930.GA6337@mirage.deb.at \
    --to=rhonda@deb.at \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal