* [pve-devel] [PATCH widget-toolkit] node: repos: only show suites warning at the top if enabled repository is affected
@ 2021-07-09 8:08 Fabian Ebner
2021-07-09 12:43 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Ebner @ 2021-07-09 8:08 UTC (permalink / raw)
To: pve-devel
The warning still shows up for the disabled repository itself, but
having a disabled repository with a bad suite is not problematic for
the configuration status as a whole.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
src/node/APTRepositories.js | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index 4a37adb..c7222fc 100644
--- a/src/node/APTRepositories.js
+++ b/src/node/APTRepositories.js
@@ -665,9 +665,6 @@ Ext.define('Proxmox.node.APTRepositories', {
(info.kind === 'ignore-pre-upgrade-warning' && !repoGrid.majorUpgradeAllowed)
) {
infos[path][idx].warnings.push(info);
- if (!suitesWarning && info.property === 'Suites') {
- suitesWarning = true;
- }
} else {
throw 'unknown info';
}
@@ -682,6 +679,10 @@ Ext.define('Proxmox.node.APTRepositories', {
if (infos[file.path] && infos[file.path][n]) {
repo.Origin = infos[file.path][n].origin || Proxmox.Utils.UnknownText;
repo.warnings = infos[file.path][n].warnings || [];
+
+ if (repo.Enabled && repo.warnings.some(w => w.property === 'Suites')) {
+ suitesWarning = true;
+ }
}
gridData.push(repo);
}
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH widget-toolkit] node: repos: only show suites warning at the top if enabled repository is affected
2021-07-09 8:08 [pve-devel] [PATCH widget-toolkit] node: repos: only show suites warning at the top if enabled repository is affected Fabian Ebner
@ 2021-07-09 12:43 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-07-09 12:43 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Ebner
On 09.07.21 10:08, Fabian Ebner wrote:
> The warning still shows up for the disabled repository itself, but
> having a disabled repository with a bad suite is not problematic for
> the configuration status as a whole.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> src/node/APTRepositories.js | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-09 12:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09 8:08 [pve-devel] [PATCH widget-toolkit] node: repos: only show suites warning at the top if enabled repository is affected Fabian Ebner
2021-07-09 12:43 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal