From: Rhonda D'Vine <rhonda@deb.at>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager 1/1] Only check deb sources.list entries
Date: Fri, 9 Jul 2021 09:24:41 +0200 [thread overview]
Message-ID: <20210709072441.8437-2-rhonda@deb.at> (raw)
In-Reply-To: <20210709072441.8437-1-rhonda@deb.at>
The check isn't specific enough, it also catches deb-src entries and
would give a false impression of security in certain circumstances, or
lead to false negatives in case you have a deb-src entry for
buster/updates even though you have bullseye-security in just the next
line -- something that isn't that uncommon for developers.
Signed-off-by: Rhonda D'Vine <rhonda@deb.at>
---
PVE/CLI/pve6to7.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.pm
index fb928a9c..30adcb19 100644
--- a/PVE/CLI/pve6to7.pm
+++ b/PVE/CLI/pve6to7.pm
@@ -1010,7 +1010,7 @@ sub check_security_repo {
($line) = split(/#/, $line);
- next if $line !~ m/^deb/; # is case sensitive
+ next if $line !~ m/^deb[[:space:]]/; # is case sensitive
my $suite;
--
2.30.2
next prev parent reply other threads:[~2021-07-09 7:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 7:24 [pve-devel] [PATCH pve-manager 0/1] " Rhonda D'Vine
2021-07-09 7:24 ` Rhonda D'Vine [this message]
2021-07-09 8:33 ` [pve-devel] [PATCH pve-manager 1/1] " Fabian Ebner
2021-07-09 8:49 ` Rhonda D'Vine
2021-07-13 4:53 ` Thomas Lamprecht
2021-07-13 4:34 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210709072441.8437-2-rhonda@deb.at \
--to=rhonda@deb.at \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.