From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 proxmox-widget-toolkit 1/1] node: tasks: use helper to format status again
Date: Thu, 8 Jul 2021 11:14:54 +0200 [thread overview]
Message-ID: <20210708091456.47891-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210708091456.47891-1-f.ebner@proxmox.com>
which avoids the all-caps "WARNINGS:" and uses the localized version.
The call was thrown out by the big overhaul in
9e059d560c872f14aef0e586010a6b6a91ce2729.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
New in v3, but essentially restoring the already applied
4294143f92f43c3288304b35de3419b035d38cd2.
src/node/Tasks.js | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/node/Tasks.js b/src/node/Tasks.js
index aa074b4..c852615 100644
--- a/src/node/Tasks.js
+++ b/src/node/Tasks.js
@@ -435,14 +435,7 @@ Ext.define('Proxmox.node.Tasks', {
return '';
}
- let parsed = Proxmox.Utils.parse_task_status(value);
- switch (parsed) {
- case 'unknown': return Proxmox.Utils.unknownText;
- case 'error': return Proxmox.Utils.errorText + ': ' + value;
- case 'ok': // fall-through
- case 'warning': // fall-through
- default: return value;
- }
+ return Proxmox.Utils.format_task_status(value);
},
},
],
--
2.30.2
WARNING: multiple messages have this Message-ID
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v3 proxmox-widget-toolkit 1/1] node: tasks: use helper to format status again
Date: Thu, 8 Jul 2021 11:14:54 +0200 [thread overview]
Message-ID: <20210708091456.47891-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210708091456.47891-1-f.ebner@proxmox.com>
which avoids the all-caps "WARNINGS:" and uses the localized version.
The call was thrown out by the big overhaul in
9e059d560c872f14aef0e586010a6b6a91ce2729.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
New in v3, but essentially restoring the already applied
4294143f92f43c3288304b35de3419b035d38cd2.
src/node/Tasks.js | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/node/Tasks.js b/src/node/Tasks.js
index aa074b4..c852615 100644
--- a/src/node/Tasks.js
+++ b/src/node/Tasks.js
@@ -435,14 +435,7 @@ Ext.define('Proxmox.node.Tasks', {
return '';
}
- let parsed = Proxmox.Utils.parse_task_status(value);
- switch (parsed) {
- case 'unknown': return Proxmox.Utils.unknownText;
- case 'error': return Proxmox.Utils.errorText + ': ' + value;
- case 'ok': // fall-through
- case 'warning': // fall-through
- default: return value;
- }
+ return Proxmox.Utils.format_task_status(value);
},
},
],
--
2.30.2
next prev parent reply other threads:[~2021-07-08 9:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 9:14 [pve-devel] [PATCH-SERIES v3] improve warnings handling in UI and add to PVE Fabian Ebner
2021-07-08 9:14 ` [pbs-devel] " Fabian Ebner
2021-07-08 9:14 ` Fabian Ebner [this message]
2021-07-08 9:14 ` [pbs-devel] [PATCH v3 proxmox-widget-toolkit 1/1] node: tasks: use helper to format status again Fabian Ebner
2021-07-08 9:50 ` [pve-devel] applied: " Thomas Lamprecht
2021-07-08 9:50 ` [pbs-devel] applied: " Thomas Lamprecht
2021-07-08 9:14 ` [pve-devel] [PATCH v3 proxmox-backup 1/1] ui: tasks: use format_task_status Fabian Ebner
2021-07-08 9:14 ` [pbs-devel] " Fabian Ebner
2021-07-08 9:45 ` [pve-devel] applied: " Thomas Lamprecht
2021-07-08 9:45 ` [pbs-devel] applied: " Thomas Lamprecht
2021-07-08 9:14 ` [pve-devel] [PATCH/RFC v3 pve-container 1/1] restore: sanitize config: use new warn() function Fabian Ebner
2021-07-08 9:14 ` [pbs-devel] " Fabian Ebner
2021-10-14 11:05 ` [pve-devel] applied: " Thomas Lamprecht
2021-10-14 11:05 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210708091456.47891-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.