all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Stefan Reiter <s.reiter@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] zfs: allow RAID0 with different-sized disks
Date: Fri, 2 Jul 2021 12:16:05 +0200	[thread overview]
Message-ID: <20210702121605.21bf837c@rosa.proxmox.com> (raw)
In-Reply-To: <20210624123013.2420174-1-s.reiter@proxmox.com>

Thanks for the patch!

checked the git-log when and how this got introduced in the first place
and it's been like that since zfs raid configuration was introduced...

I think the change makes sense - in addition to the case of RAID0 with
different sizes, it would also prevent RAID10 with the mirror pairs having
different size (2x 15G and 2x 10G in my tests) - which I also can imagine
is a use-case for some users

Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>

On Thu, 24 Jun 2021 14:30:13 +0200
Stefan Reiter <s.reiter@proxmox.com> wrote:

> zfs_mirror_size_check is already called in get_zfs_raid_setup when
> necessary, so don't call it unconditionally, as this will cause a
> false-positive error on RAID0 devices (where size mismatches are fine).



> 
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>  proxinstall | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/proxinstall b/proxinstall
> index a6176d2..213486a 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -1426,8 +1426,6 @@ sub extract_data {
>  		my ($size, $osdev, $efidev) =
>  		    partition_bootable_disk($devname, $config_options->{hdsize}, 'BF01');
>  
> -		zfs_mirror_size_check($disksize, $size) if $disksize;
> -
>  		push @$bootdevinfo, {
>  		    esp => $efidev,
>  		    devname => $devname,





  reply	other threads:[~2021-07-02 10:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 12:30 Stefan Reiter
2021-07-02 10:16 ` Stoiko Ivanov [this message]
2022-03-16 15:05 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210702121605.21bf837c@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.reiter@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal