all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] api: backup info: prefer kebab-case
Date: Fri,  2 Jul 2021 11:40:37 +0200	[thread overview]
Message-ID: <20210702094037.38196-1-f.ebner@proxmox.com> (raw)

And also add the 'backup-info' endpoint to the index.

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 PVE/API2/BackupInfo.pm    | 2 +-
 PVE/API2/Cluster.pm       | 3 ++-
 www/manager6/dc/Backup.js | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/PVE/API2/BackupInfo.pm b/PVE/API2/BackupInfo.pm
index 4c461e59..53a2ecfb 100644
--- a/PVE/API2/BackupInfo.pm
+++ b/PVE/API2/BackupInfo.pm
@@ -51,7 +51,7 @@ __PACKAGE__->register_method({
 
 __PACKAGE__->register_method({
     name => 'get_guests_not_in_backup',
-    path => 'not_backed_up',
+    path => 'not-backed-up',
     method => 'GET',
     protected => 1,
     description => "Shows all guests which are not covered by any backup job.",
diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
index 43dfa65f..2054ba76 100644
--- a/PVE/API2/Cluster.pm
+++ b/PVE/API2/Cluster.pm
@@ -66,7 +66,7 @@ __PACKAGE__->register_method ({
 
 __PACKAGE__->register_method ({
     subclass => "PVE::API2::BackupInfo",
-    path => 'backupinfo',
+    path => 'backup-info',
 });
 
 __PACKAGE__->register_method ({
@@ -131,6 +131,7 @@ __PACKAGE__->register_method ({
 	    { name => 'replication' },
 	    { name => 'tasks' },
 	    { name => 'backup' },
+	    { name => 'backup-info' },
 	    { name => 'ha' },
 	    { name => 'status' },
 	    { name => 'nextid' },
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 6be545ee..f06c25ff 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -797,7 +797,7 @@ Ext.define('PVE.dc.BackupView', {
 	    sorters: 'vmid',
 	    proxy: {
 		type: 'proxmox',
-		url: 'api2/json/cluster/backupinfo/not_backed_up',
+		url: 'api2/json/cluster/backup-info/not-backed-up',
 	    },
 	});
 
-- 
2.30.2





                 reply	other threads:[~2021-07-02  9:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210702094037.38196-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal