From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 1/5] APTRepositories: change separation style between panels
Date: Wed, 30 Jun 2021 17:14:55 +0200 [thread overview]
Message-ID: <20210630151459.231895-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210630151459.231895-1-d.csapak@proxmox.com>
having double borders does not look so nice, separate them with a bit
of padding
also change the warning panel to a simple header
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/node/APTRepositories.js | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index 6812d46..7544a23 100644
--- a/src/node/APTRepositories.js
+++ b/src/node/APTRepositories.js
@@ -24,6 +24,8 @@ Ext.define('Proxmox.node.APTRepositoriesErrors', {
store: {},
+ border: false,
+
viewConfig: {
stripeRows: false,
getRowClass: () => 'proxmox-invalid-row',
@@ -52,6 +54,8 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', {
cls: 'proxmox-apt-repos', // to allow applying styling to general components with local effect
+ border: false,
+
tbar: [
{
text: gettext('Reload'),
@@ -350,18 +354,25 @@ Ext.define('Proxmox.node.APTRepositories', {
items: [
{
- title: gettext('Warning'),
- name: 'repositoriesMainWarning',
- xtype: 'panel',
+ xtype: 'header',
+ baseCls: 'x-panel-header',
bind: {
+ hidden: '{!mainWarning}',
title: '{mainWarning}',
+ },
+ },
+ {
+ xtype: 'box',
+ bind: {
hidden: '{!mainWarning}',
},
+ height: 5,
},
{
xtype: 'proxmoxNodeAPTRepositoriesErrors',
name: 'repositoriesErrors',
hidden: true,
+ padding: '0 0 5 0',
bind: {
hidden: '{noErrors}',
},
--
2.30.2
next prev parent reply other threads:[~2021-06-30 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 15:14 [pve-devel] [PATCH widget-toolkit 0/5] some APTRepositories improvements Dominik Csapak
2021-06-30 15:14 ` Dominik Csapak [this message]
2021-06-30 15:14 ` [pve-devel] [PATCH widget-toolkit 2/5] APTRepositories: make panel scrollable Dominik Csapak
2021-06-30 15:14 ` [pve-devel] [PATCH widget-toolkit 3/5] APTRepositories: change updating button text/state to viewcontroller Dominik Csapak
2021-06-30 15:14 ` [pve-devel] [PATCH widget-toolkit 4/5] APTRepositories: make the Suites warnings inline errors Dominik Csapak
2021-06-30 15:14 ` [pve-devel] [PATCH widget-toolkit 5/5] APTRepositories: remove unecessary selection model Dominik Csapak
2021-06-30 19:36 ` [pve-devel] applied-series: [PATCH widget-toolkit 0/5] some APTRepositories improvements Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630151459.231895-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal