all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2 0/3] acme: add sleep for dns record propagation
Date: Mon, 28 Jun 2021 18:41:06 +0000	[thread overview]
Message-ID: <20210628184109.110296-1-s.ivanov@proxmox.com> (raw)

changes v1 -> v2 (based on Thomas' feedback - huge thx!):
* moved the sleep to only run for setup not for teardown
* added a check to only sleep and print the message if the delay is > 0
  for consistency, and to be able to skip it (e.g. for a simple
  powerdns-setup)
* while looking through the code found a small glitch in an error
  message (the fix is in patch 1/3)

forgot to mention that the patches were developed and tested on top of
the current stable-1 branch (they apply cleanly on master, but I did not
explicitly test on master)

cover-letter for v1:
The issue was brought up in our community forum:
https://forum.proxmox.com/threads/acme-configuration-via-gui.91381/

While I could not directly reproduce it (writing to a pdns-database is
faster than waiting on cloud-flare to propagate their records) I
compared the task-log to the one from PMG.

The use of tokio::time::sleep was taken from the other delays in
api2::node::certificate, for the rest I mostly trusted the compiler
warnings and rustfmt.


Stoiko Ivanov (3):
  acme: plugin: fix error message
  config: acme: make validation_delay crate public
  fix #3496: acme: plugin: add sleep for dns propagation

 src/acme/plugin.rs        | 19 +++++++++++++++++--
 src/config/acme/plugin.rs |  2 +-
 2 files changed, 18 insertions(+), 3 deletions(-)

-- 
2.20.1





             reply	other threads:[~2021-06-28 18:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 18:41 Stoiko Ivanov [this message]
2021-06-28 18:41 ` [pbs-devel] [PATCH proxmox-backup v2 1/3] acme: plugin: fix error message Stoiko Ivanov
2021-06-28 18:41 ` [pbs-devel] [PATCH proxmox-backup v2 2/3] config: acme: make validation_delay crate public Stoiko Ivanov
2021-06-28 18:41 ` [pbs-devel] [PATCH proxmox-backup v2 3/3] fix #3496: acme: plugin: add sleep for dns propagation Stoiko Ivanov
2021-07-05  6:32 ` [pbs-devel] applied-series: [PATCH proxmox-backup v2 0/3] acme: add sleep for dns record propagation Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628184109.110296-1-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal